Fix an issue where in a proper set of documentation, a field_info.annotation can be of type "type" #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The except clause of _get_array_outer_type can return field_info.annotation as a list, so the __args__ element is not valid. Check for this type and return the raw element.
The type that is not being properly handled is "type". Odd, for certain, but never an issue before the latest version of BlackSheep.
|
@RobertoPrevato - Have you thought about appointing some maintainers? Some of these PRs are years old. Many of us want to help this library grow. I personally really like it and I use it extensively. I've deployed dozens of projects using it as a framework. If you are running out of personal time, please consider letting the community help with the maintenance and upkeep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix the following issue:
#492