Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fails when a keyword is set to an invalid regex expression #173

Open
iliapolo opened this issue Feb 17, 2021 · 0 comments
Open

Action fails when a keyword is set to an invalid regex expression #173

iliapolo opened this issue Feb 17, 2021 · 0 comments
Assignees

Comments

@iliapolo
Copy link

This commit made it so that keywords are treated as regular expressions, as opposed to literal strings before.

This resulted in our action failing with:

issue content: chore: fix unmatched parenthesis in issue-label-assign
Error: Invalid regular expression: /(?!-)\bevent-bridge)\b(?!-)/: Unmatched ')'

While its true we had missing parentheses in our configuration, i'm not sure this was the intended behavior, as the commit title seems to suggest it was just meant validate the keyword itself was surrounded with alphanumeric characters.

If it is meant as a regular expression, I suggest to add this to the documentation, and mention this is actually a breaking change. If not, the keyword needs to be properly escaped.

@iliapolo iliapolo changed the title Action fail when a keyword is set to an invalid regex expression Action fails when a keyword is set to an invalid regex expression Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants