-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deno configuration and update type definitions #355
Conversation
…dd Copilot instructions
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 68 out of 83 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- .husky/pre-commit: Language not supported
- .swcrc: Language not supported
- deno.json: Language not supported
- nest-cli.json: Language not supported
- package.json: Language not supported
- lint-staged.config.js: Evaluated as low risk
- src/constants/index.ts: Evaluated as low risk
- .eslintrc.js: Evaluated as low risk
- src/common/abstract-client.service.ts: Evaluated as low risk
- src/decorators/api-page-response.decorator.ts: Evaluated as low risk
- src/common/abstract.entity.ts: Evaluated as low risk
- src/common/dto/page.dto.ts: Evaluated as low risk
- src/common/dto/page-options.dto.ts: Evaluated as low risk
- src/common/dto/abstract.dto.ts: Evaluated as low risk
- src/common/dto/page-meta.dto.ts: Evaluated as low risk
…ve authentication strategy
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 72 out of 87 changed files in this pull request and generated 2 suggestions.
Files not reviewed (15)
- .husky/pre-commit: Language not supported
- .swcrc: Language not supported
- deno.json: Language not supported
- nest-cli.json: Language not supported
- package.json: Language not supported
- src/constants/index.ts: Evaluated as low risk
- lint-staged.config.js: Evaluated as low risk
- .eslintrc.js: Evaluated as low risk
- src/common/abstract-client.service.ts: Evaluated as low risk
- src/common/abstract.entity.ts: Evaluated as low risk
- src/common/dto/page.dto.ts: Evaluated as low risk
- src/common/dto/page-options.dto.ts: Evaluated as low risk
- src/common/dto/abstract.dto.ts: Evaluated as low risk
- src/common/dto/page-meta.dto.ts: Evaluated as low risk
- src/common/dto/create-translation.dto.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
eslint.config.mjs:63
- The use of
projectService: true
inparserOptions
is not a standard ESLint option. This might be a mistake.
projectService: true,
To build the App using Deno, run: | ||
|
||
```bash | ||
deno task buildr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script 'deno task buildr' should be 'deno task build'.
deno task buildr | |
deno task build |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
…development scripts
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 72 out of 87 changed files in this pull request and generated 2 suggestions.
Files not reviewed (15)
- .husky/pre-commit: Language not supported
- .swcrc: Language not supported
- deno.json: Language not supported
- nest-cli.json: Language not supported
- package.json: Language not supported
- src/constants/index.ts: Evaluated as low risk
- lint-staged.config.js: Evaluated as low risk
- .eslintrc.js: Evaluated as low risk
- src/common/abstract-client.service.ts: Evaluated as low risk
- src/common/abstract.entity.ts: Evaluated as low risk
- src/common/dto/page-options.dto.ts: Evaluated as low risk
- src/common/dto/page.dto.ts: Evaluated as low risk
- src/common/dto/abstract.dto.ts: Evaluated as low risk
- src/common/dto/page-meta.dto.ts: Evaluated as low risk
- src/common/dto/create-translation.dto.ts: Evaluated as low risk
Entity extends AbstractEntity<Dto>, | ||
Dto extends AbstractDto, | ||
>(options?: unknown): Dto[] { | ||
return _.compact( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using lodash functions like _.compact and _.map is unnecessary here. Consider using native JavaScript methods like Array.prototype.filter and Array.prototype.map instead.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
…nce TypeScript support, and refactor code for improved readability
This pull request includes several significant updates to the project, focusing on configuration changes, support for new development environments, and updates to the linting setup. Configuration changes:
New development environment support:
Linting setup updates:
Additional changes:
|
This pull request introduces a Deno configuration file and updates type definitions across various files. It also adds a new Deno start script to facilitate development. Additionally, several imports have been refined for clarity, and lodash functions have been replaced with native JavaScript methods where appropriate. These changes enhance type safety and improve the overall structure of the codebase.
==============
Note: Build & Run doesn't work yet