Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno configuration and update type definitions #355

Merged
merged 14 commits into from
Nov 23, 2024
Merged

Conversation

NarHakobyan
Copy link
Owner

@NarHakobyan NarHakobyan commented Oct 20, 2024

This pull request introduces a Deno configuration file and updates type definitions across various files. It also adds a new Deno start script to facilitate development. Additionally, several imports have been refined for clarity, and lodash functions have been replaced with native JavaScript methods where appropriate. These changes enhance type safety and improve the overall structure of the codebase.

==============

Note: Build & Run doesn't work yet

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 68 out of 83 changed files in this pull request and generated 1 suggestion.

Files not reviewed (15)
  • .husky/pre-commit: Language not supported
  • .swcrc: Language not supported
  • deno.json: Language not supported
  • nest-cli.json: Language not supported
  • package.json: Language not supported
  • lint-staged.config.js: Evaluated as low risk
  • src/constants/index.ts: Evaluated as low risk
  • .eslintrc.js: Evaluated as low risk
  • src/common/abstract-client.service.ts: Evaluated as low risk
  • src/decorators/api-page-response.decorator.ts: Evaluated as low risk
  • src/common/abstract.entity.ts: Evaluated as low risk
  • src/common/dto/page.dto.ts: Evaluated as low risk
  • src/common/dto/page-options.dto.ts: Evaluated as low risk
  • src/common/dto/abstract.dto.ts: Evaluated as low risk
  • src/common/dto/page-meta.dto.ts: Evaluated as low risk

.vscode/copilot-instructions.md Show resolved Hide resolved
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 72 out of 87 changed files in this pull request and generated 2 suggestions.

Files not reviewed (15)
  • .husky/pre-commit: Language not supported
  • .swcrc: Language not supported
  • deno.json: Language not supported
  • nest-cli.json: Language not supported
  • package.json: Language not supported
  • src/constants/index.ts: Evaluated as low risk
  • lint-staged.config.js: Evaluated as low risk
  • .eslintrc.js: Evaluated as low risk
  • src/common/abstract-client.service.ts: Evaluated as low risk
  • src/common/abstract.entity.ts: Evaluated as low risk
  • src/common/dto/page.dto.ts: Evaluated as low risk
  • src/common/dto/page-options.dto.ts: Evaluated as low risk
  • src/common/dto/abstract.dto.ts: Evaluated as low risk
  • src/common/dto/page-meta.dto.ts: Evaluated as low risk
  • src/common/dto/create-translation.dto.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

eslint.config.mjs:63

  • The use of projectService: true in parserOptions is not a standard ESLint option. This might be a mistake.
projectService: true,

To build the App using Deno, run:

```bash
deno task buildr
Copy link
Preview

Copilot AI Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script 'deno task buildr' should be 'deno task build'.

Suggested change
deno task buildr
deno task build

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Repository owner deleted a comment from copilot-pull-request-reviewer bot Nov 11, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 72 out of 87 changed files in this pull request and generated 2 suggestions.

Files not reviewed (15)
  • .husky/pre-commit: Language not supported
  • .swcrc: Language not supported
  • deno.json: Language not supported
  • nest-cli.json: Language not supported
  • package.json: Language not supported
  • src/constants/index.ts: Evaluated as low risk
  • lint-staged.config.js: Evaluated as low risk
  • .eslintrc.js: Evaluated as low risk
  • src/common/abstract-client.service.ts: Evaluated as low risk
  • src/common/abstract.entity.ts: Evaluated as low risk
  • src/common/dto/page-options.dto.ts: Evaluated as low risk
  • src/common/dto/page.dto.ts: Evaluated as low risk
  • src/common/dto/abstract.dto.ts: Evaluated as low risk
  • src/common/dto/page-meta.dto.ts: Evaluated as low risk
  • src/common/dto/create-translation.dto.ts: Evaluated as low risk

.vscode/copilot-instructions.md Show resolved Hide resolved
Entity extends AbstractEntity<Dto>,
Dto extends AbstractDto,
>(options?: unknown): Dto[] {
return _.compact(
Copy link
Preview

Copilot AI Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using lodash functions like _.compact and _.map is unnecessary here. Consider using native JavaScript methods like Array.prototype.filter and Array.prototype.map instead.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@NarHakobyan NarHakobyan marked this pull request as ready for review November 23, 2024 12:36
@NarHakobyan
Copy link
Owner Author

This pull request includes several significant updates to the project, focusing on configuration changes, support for new development environments, and updates to the linting setup.

Configuration changes:

  • .eslintrc.js: Removed extensive ESLint configuration and rules, streamlining the file.
  • .github/workflows/lint.yml: Updated Node.js version to use lts/* and upgraded lint-action to version 2.
  • nest-cli.json: Switched to using swc for building with a specified .swcrc configuration file.

New development environment support:

  • README.md: Added detailed instructions and scripts for Node, Deno, and Bun development environments, including build and test commands. [1] [2] [3]
  • deno.json: Added configuration for Deno, including imports, compiler options, tasks, formatting, and linting rules.

Linting setup updates:

Additional changes:

  • .swcrc: Added a new SWC configuration file to support TypeScript and various plugins.
  • .vscode/copilot-instructions.md: Added guidelines for using Copilot, including code style and documentation requirements.
  • package.json: Updated scripts to support new development environments and build processes, including Bun and Deno.

@NarHakobyan NarHakobyan merged commit 85d1d03 into main Nov 23, 2024
1 check failed
@NarHakobyan NarHakobyan deleted the deno-integration branch November 23, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant