Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Title #3

wants to merge 4 commits into from

Conversation

Namanrepo
Copy link

Description

@oppiabotlocal
Copy link

oppiabotlocal bot commented Mar 24, 2021

Hi @Naman-1234 , Its been more than 24 Hrs, since Requested Review. Please Review this. Thanks

Repository owner deleted a comment from oppiabotlocal bot Mar 24, 2021
Repository owner deleted a comment from oppiabotlocal bot Mar 24, 2021
Repository owner deleted a comment from oppiabotlocal bot Mar 24, 2021
@oppiabotlocal
Copy link

oppiabotlocal bot commented Mar 25, 2021

Assigning @Naman-1234 for code owner reviews. Thanks!

Naman-1234
Naman-1234 requested changes Mar 25, 2021
View reviewed changes
Copy link
Owner

@Naman-1234 Naman-1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHanges requested.

Naman-1234
Naman-1234 requested changes Mar 25, 2021
View reviewed changes
Copy link
Owner

@Naman-1234 Naman-1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested Changes.

@oppiabotlocal
Copy link

oppiabotlocal bot commented Mar 25, 2021

Unassigning @Naman-1234 since the review is done.

@oppiabotlocal
Copy link

oppiabotlocal bot commented Mar 25, 2021

Hi @Namanrepo, it looks like some changes were requested on this pull request by @Naman-1234. PTAL. Thanks!

@oppiabotlocal
Copy link

oppiabotlocal bot commented Mar 26, 2021

Removing LGTM Label since Changes are Requested.

1 similar comment
@oppiabotlocal
Copy link

oppiabotlocal bot commented Mar 26, 2021

Removing LGTM Label since Changes are Requested.

@oppiabotlocal oppiabotlocal bot removed the PR: LGTM label Mar 26, 2021
Repository owner deleted a comment from oppiabotlocal bot Mar 26, 2021
Repository owner deleted a comment from oppiabotlocal bot Mar 26, 2021
Repository owner deleted a comment from oppiabotlocal bot Mar 26, 2021
@oppiabotlocal oppiabotlocal bot removed the PR: LGTM label Mar 26, 2021
Repository owner deleted a comment from oppiabotlocal bot Mar 26, 2021
@oppiabotlocal oppiabotlocal bot removed the PR: LGTM label Mar 26, 2021
Repository owner deleted a comment from oppiabotlocal bot Mar 26, 2021
@oppiabotlocal oppiabotlocal bot removed the PR: LGTM label Mar 26, 2021
@oppiabotlocal
Copy link

oppiabotlocal bot commented Mar 26, 2021

Hi, @Namanrepo, Removing LGTM Label since some Changes are Requested.

@oppiabotlocal
Copy link

oppiabotlocal bot commented Mar 30, 2021

Hi @Namanrepo, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@Naman-1234 Naman-1234 self-requested a review April 1, 2021 10:15
Naman-1234
Naman-1234 requested changes Apr 1, 2021
View reviewed changes
Copy link
Owner

@Naman-1234 Naman-1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perform some changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naman-1234 Naman-1234 Naman-1234 requested changes

Assignees

@Namanrepo Namanrepo

Labels
PR: don't merge - STALE BUILD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Namanrepo @Naman-1234 @nlok5923