Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing const for uint32_t* frameIndex in PFun_slGetNewFrameToken #37

Open
QDanteQ opened this issue Mar 15, 2024 · 2 comments
Open

Missing const for uint32_t* frameIndex in PFun_slGetNewFrameToken #37

QDanteQ opened this issue Mar 15, 2024 · 2 comments
Labels
ready Changes made and ready for release. Will close when “done”.

Comments

@QDanteQ
Copy link

QDanteQ commented Mar 15, 2024

Hello, I guess you've missed const specifier for uint32_t* frameIndex. There's const in function declaration (down the file) and in implementation.

using PFun_slGetNewFrameToken = sl::Result(sl::FrameToken*& token, uint32_t* frameIndex);

@jake-nv
Copy link
Collaborator

jake-nv commented Mar 20, 2024

Nice catch.

This won’t be in the upcoming release, but it will be in the one after.

@jake-nv jake-nv added the ready Changes made and ready for release. Will close when “done”. label Mar 23, 2024
@jake-nv
Copy link
Collaborator

jake-nv commented Jun 5, 2024

We haven’t forgotten about this. This wasn’t in 2.4.10 because it was done after a re-org of sl.h that now can’t be cherry-picked into 2.4.x. It’ll go in with the next mass-integration (likely 2.5 or the equivalent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Changes made and ready for release. Will close when “done”.
Projects
None yet
Development

No branches or pull requests

2 participants