Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unittests for cluster config logic #171

Open
Kipok opened this issue Oct 7, 2024 · 0 comments
Open

Add unittests for cluster config logic #171

Kipok opened this issue Oct 7, 2024 · 0 comments

Comments

@Kipok
Copy link
Collaborator

Kipok commented Oct 7, 2024

There are now many functions in https://github.com/Kipok/NeMo-Skills/blob/main/nemo_skills/pipeline/utils.py that are related to config management (e.g. adding mounts from env vars, checking data on cluster, defining env vars optional and required, etc.). We don't have any tests for that logic and need to add them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant