Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for extra arguments correctness to some of the scripts #161

Open
Kipok opened this issue Oct 3, 2024 · 0 comments
Open

Add checks for extra arguments correctness to some of the scripts #161

Kipok opened this issue Oct 3, 2024 · 0 comments

Comments

@Kipok
Copy link
Collaborator

Kipok commented Oct 3, 2024

We cannot check all arguments, since sometimes they can only run in the container (e.g. nemo/trtllm), but at least for the arguments that are passed to the scripts that run inside nemo-skills container we can try to parse anything that doesn't start with "--" and then try to instantiate the underlying dataclass to be able to throw errors before the job is submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant