Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plans using peak stats fail in print summary #10

Open
ambarb opened this issue Jul 28, 2018 · 7 comments
Open

plans using peak stats fail in print summary #10

ambarb opened this issue Jul 28, 2018 · 7 comments
Labels

Comments

@ambarb
Copy link
Contributor

ambarb commented Jul 28, 2018

add flow control to assign the key a number if it does not have one. this affects alignment of m1 and m3 (m3_check() and the align generator in the profile.)

@awalter-bnl
Copy link
Contributor

@ambarb I am not sure I understand what you want here, any suggestions? Let me know when is a good time to stop by and look at the growing list of issues at SIX (preferably with @bisogni or yourself present). Feel free to put something on my calender, I think you have mentioned that you would like to wait until after Tuesday but I can come earlier if you prefer.

@ambarb
Copy link
Contributor Author

ambarb commented Jul 30, 2018

This is also related to
bluesky/bluesky#1017

I am not sure if this work proceeding in the above will be something that rolls out soon.

And in general the discussion found here applies.
bluesky/bluesky#1075

@ambarb
Copy link
Contributor Author

ambarb commented Jul 30, 2018

let me talk with @bisogni and we will set up a time.

@mrakitin
Copy link
Member

That is a high priority issue to be resolved (according to @bisogni).

@mrakitin mrakitin added the bug label Jul 11, 2019
@ambarb
Copy link
Contributor Author

ambarb commented Jul 11, 2019

For the m3 alignment? Or the larger problem of peaks not playing nice with print_summary

@mrakitin
Copy link
Member

I think it's for the larger problem.

@ambarb
Copy link
Contributor Author

ambarb commented Sep 18, 2019

I have one or two issue reports in Bluesky about this. I think the others have suggested that we make plans that are more defensive rather than enabling this feature in Bluesky, which would deliver a functionality that spec has.

bluesky/bluesky#1017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants