enhancement: energy_loss update

[dmulash]

No description provided.

[RHammond2]

Resolves #10

[RHammond2]

This is an excellent start @dmulash, thanks for updating all the impacted methods!

I left a lot of comments, but they're mostly relating to the use of an electrical losses method, rather than an input. I have a couple of questions in there as well that'd be great to get your input on, especially while we're modifying the code. I also made a handful of smaller changes myself just to reduce some of the back and forth.

[dmulash]

Hi @RHammond2,

Apart from your suggested changes (eliminate with_losses everywhere, substitute loss_ratio with environmental_loss_ratio, and keep the logic from energy_potential() for wake_losses()), I have also updated the config files for floating and fixed to include a line specifying the turbine_type. Additionally, I modified the example notebook to correct instances where it was calling with_losses for breakdowns.

Feel free to adjust as needed!

[RHammond2]

It looks like the energy losses weren't applied in this method, which should be done just before the AEP conditional.

[RHammond2]

Basically the section you removed should be replaced with something like:

losses = self.energy_losses(...)  # pass the parameters that were used for the energy potential basis 
production = potential - losses

[RHammond2]

I realized there was an error in how this was done, which was mostly my fault, so I fixed that. I would double check the remaining losses calculations, and replicate the process in this method to ensure that both the control flow and the calculations are correct.

[RHammond2]

This section should be roughly in the form of:

if not losses_breakdown:
    production = ... # the code that's there already
    losses = potentail.copy()
    losses["total_losses"] = potential.values - production.values  # can use a different column name
else:
    # raise an error for if by == "turbine" because detailed breakdowns are only for the wind farm
    environmental_lr = self.environmental_loss_ratio()
    availability_lr = self.availability(which="energy", by="windfarm", frequency="month-year")
    ... # the remaining loss ratios

    losses = potential.copy
    losses = losses.assign(
        environmental_losses=environmental_lr,
        availability_losses=availability_lr,
        ... # the remaining lossses
    ).rename(columns={}) # final step if you think we should have them displayed more nicely

# convert to desired units

# aggregate to apporpriate time scale ("annual", "project")

# apply aep

# apply per_capacity

[RHammond2]

From our conversation: only calculate the loss ratio, not the actual losses. (removed from the example above)

[RHammond2]

This should really be incorporated into the energy_losses method using a new keyword argument called breakdown because the loss amounts may need to be broken down across time as well.

[RHammond2]

@RHammond2 fix this to get potential as the base energy, so losses can be subtracted.