Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fv_diagnostics.F90 #293

Merged

Conversation

kaiyuan-cheng
Copy link
Contributor

Description

Fix the unit of total energy diagnostic and clean up unused nh_total_energy().

Fixes #235

How Has This Been Tested?

This was tested with SHiELD on Gaea. No answer changes.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Fix the unit of total energy diagnostic and clean up unused nh_total_energy().
Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This should be brought over into GitLab also.

@laurenchilutti
Copy link
Contributor

I am merging this now and will be sure to bring this back to Gitlab and other branches.

@laurenchilutti laurenchilutti merged commit c59f36d into NOAA-GFDL:main Oct 10, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total energy diagnostic units metadata is incorrect
4 participants