update for land IAU to ccpp-physics noahmp

[tsga]

This ensures consistency between the NoahMP component model and the UFS WM/ccpp physics Noahmp after the land IAU capability is added to the later. Specifically the noahmpdrv_init function has three parameters (Land IAU related DDTs) passed as optional, enabling the component model to use the noahmpdrv_init function without any more changes right now.

Dependent on pull request: ufs-community/ccpp-physics#222

[tsga]

Tagging relevant people here. Please add (tag) anyone you think should be aware.
@uturuncoglu, @barlage, @CoryMartin-NOAA, @ClaraDraper-NOAA, @CatherineThomas-NOAA, @junwang-noaa

[CoryMartin-NOAA]

I don't know this code well but these changes seem correct from what I can tell

[uturuncoglu]

I have just put couple of comment to clarify the implementation.

[barlage]

@tsga thanks for adding the IAU code here; I had a comment on that yesterday that apparently I didn't send; have you tried to compile and maybe run the land component reg test?

@uturuncoglu I assume there will need to be additions here

[tsga]

@tsga thanks for adding the IAU code here; I had a comment on that yesterday that apparently I didn't send; have you tried to compile and maybe run the land component reg test?

@uturuncoglu I assume there will need to be additions here

@barlage yes, the land component related reg tests passed after all the changes were made. I am now running the whole UWM regression tests.

And I have now added the CMakeLists.txt you mentioned to @uturuncoglu to noahmp repo as well (It is also part of the UWM repo, so I had modified it in the UWM repo--probably why the tests didn't fail).

[uturuncoglu]

@tsga Thanks. This looks fine. Just to be sure, did you run land component related RTs? If so, are they passing without any issue?

[tsga]

@tsga Thanks. This looks fine. Just to be sure, did you run land component related RTs? If so, are they passing without any issue?

@uturuncoglu yes, All of the regression tests listed in "rt.conf" pass. Yesterday, "datm_cdeps_lm4_gswp3_intel" did fail, but it passes now after I updated the LM4-driver repo. The new land iau test (control_c48_lnd_iau_intel) needs to be run with the -c switch because the baseline outputs are not yet copied in hera (and the other test platforms).

[barlage]

@tsga what did you change in LM4? did you contact the LM4 group about those changes?

[tsga]

@tsga what did you change in LM4? did you contact the LM4 group about those changes?

No, I didn't change anything. I only needed to get my branch up to date with all the develop branch of UFSWM and its submodules, and everything works OK.

[barlage]

@tsga what did you change in LM4? did you contact the LM4 group about those changes?

No, I didn't change anything. I only needed to get my branch up to date with all the develop branch of UFSWM and its submodules, and everything works OK.

OK, got it. I misinterpreted what you were saying.

[ClaraDraper-NOAA]

Looks OK to me - just one small comment. Thanks @tsga

[ClaraDraper-NOAA]

@tsga I reviewed this repo as this is where the science is done. Would you like to review the related PRs too?

[tsga]

@tsga I reviewed this repo as this is where the science is done. Would you like to review the related PRs too?

Thank you @ClaraDraper-NOAA. I think this is enough. The other two repo's will be reviewed by the code owners for dependency etc.

[tsga]

@uturuncoglu It seems the second test is failing because the files "lnd_iau_mod.F90" and "lnd_iau_mod.meta" are not copied to the noahmp directory. Can you please rerun the checks with the feature/lnd_iau branch contents and let me know if there is anything else to be done to merge this PR (the other related PRs are waiting for this to be complete).

[uturuncoglu]

@tsga Okay. Run it again. Let's see what happens.

[tsga]

@barlage Mike, now that the tests are all passed, can you please mark this PR as approved.

[barlage]

Confirmed four files are identical to ccpp-physics

[FernandoAndrade-NOAA]

Testing for 2415 has completed, please continue with the merge process, thank you.

[jkbk2004]

@uturuncoglu @barlage can you merge this pr?

[uturuncoglu]

@jkbk2004 merged.