Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing cloud fractions for RRFS ensemble members #800

Open
JiliDong-NOAA opened this issue Mar 13, 2024 · 1 comment
Open

missing cloud fractions for RRFS ensemble members #800

JiliDong-NOAA opened this issue Mar 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JiliDong-NOAA
Copy link
Contributor

JiliDong-NOAA commented Mar 13, 2024

Description

Cloud fractions are all zeroes for RRFS ensemble members using GFS PBL and G-F convection.

The fix will add SGS cloud to ccpp SDF and change conv_cf_opt to Xu-Randall for convective cloud fraction computation for those members.

conv_cf_opt will be added as an input namelist parameter for runtime switch (conv_cf_opt=1 for GFS PBL members).

To Reproduce:

What compilers/machines are you seeing this with?
Hera
Give explicit steps to reproduce the behavior.

  1. Run RRFS ensemble members 1 and 4 (ccpp suite RRFSens_phy1 and RRFSens_phy4)
  2. check TCDC in grib2 or cloud fraction in history netcdf
  3. they are all zeroes

Additional context

Add any other context about the problem here.
Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:

  • needs to be fixed also in noaa-emc/nems/issues/<issue_number>
  • needed for noaa-emc/fv3atm/pull/<pr_number>

Output

Screenshots
If applicable, drag and drop screenshots to help explain your problem.

output logs
If applicable, include relevant output logs.
Either drag and drop the entire log file here (if a long log) or

paste the code here (if a short section of log)

Testing:

  1. Have you tested the code changes? On what platforms?
    Yes. On Hera
  2. Have you run regression test in ufs-weather-model or ufs-s2s-model with code changes?
    Not yet. Will do it next.
  • Will the baseline results change?
  • If the baseline results change, is it expected? Please give brief explanation.

Several tests for a single case (init 2023/05/10/06Z) have been performed by:

  1. using progcld_thompson_wsm6 in radiation_clouds.f
  2. using sgscloud_radpre with CB
  3. using sgscloud_radpre with XR

Here are total/low/medium/high cloud fractions and downward short wave radiation flux at surface:
cldfra_comparison_f24.pptx
cldfra_comparison_f36.pptx
dswrfsfc.pptx

Dependent PRs:

ufs-community/ccpp-physics#186

@JiliDong-NOAA
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant