Merge a new atms_npp.yaml file to replace the old atms_npp_qc_bc.yaml.

[xyzemc]

The file name has been changed to the standard of the templates yaml file.
The new yaml file also included the following items:

• added the Clouds Inputs
• removed the 'circle domain check' filter, and added the online domain check filter.
• changed the channel use flag to be same as it in RRFSv1
• changed the ioda file name with the standard of other data type

[SamuelDegelia-NOAA]

Do you know what the flag all filter variables if any test variable is out of bounds option does? That option is not enabled for our mesonet yamls. Also, for the mesonet yamls the minvalue and maxvalue keys are are indented under the main filter section and not under test variables. I am not sure if that matters though.

[xyzemc]

Sorry, I don't know. Let's say if @HuiLiu-NOAA can answer this question.

[HuiLiu-NOAA]

1. "flag all filter variables if any test variable is out of bounds" can be removed here since only one test variable is involved.
2. I think minvalue and maxvalue keys should be listed under "test variables"

[SamuelDegelia-NOAA]

Thanks @HuiLiu-NOAA for the input. For #⁠2, it seems like it worked for mesonet obs with the min/maxvalue indented under the filter and not under test variables. So maybe it works either way?

[HuiLiu-NOAA]

I think it may be better to move minvalue and maxvalue keys under "test variables", just to be logically more clear.

[SamuelDegelia-NOAA]

Also, could you add an obs localizations: section like in the existing atms_npp_qc_bc.yaml file?

[xyzemc]

Also, could you add an obs localizations: section like in the existing atms_npp_qc_bc.yaml file?

I have added back the localization part.

[HuiLiu-NOAA]

Agree. it may work either way.

…

On Wed, Nov 27, 2024 at 10:42 AM Samuel Degelia ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In rrfs-test/validated_yamls/templates/obtype_config/atms_npp.yaml <#237 (comment)>: > + # Regional Domain Check + - filter: Bounds Check + filter variables: + - name: brightnessTemperature + channels: *atms_npp_channels + test variables: + - name: GeoVaLs/observable_domain_mask + flag all filter variables if any test variable is out of bounds: true + minvalue: 0.0 + maxvalue: 0.5 Thanks @HuiLiu-NOAA <https://github.com/HuiLiu-NOAA> for the input. For #⁠2, it seems like it worked for mesonet obs with the min/maxvalue indented under the filter and not under test variables. So maybe it works either way? — Reply to this email directly, view it on GitHub <#237 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOF252DUDNVLY2FAQU36BT32CX767AVCNFSM6AAAAABSRFFFXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRVGY2TCOBVHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[xyzemc]

Agree. it may work either way.
…
On Wed, Nov 27, 2024 at 10:42 AM Samuel Degelia @.> wrote: @.* commented on this pull request. ------------------------------ In rrfs-test/validated_yamls/templates/obtype_config/atms_npp.yaml <#237 (comment)>: > + # Regional Domain Check + - filter: Bounds Check + filter variables: + - name: brightnessTemperature + channels: atms_npp_channels + test variables: + - name: GeoVaLs/observable_domain_mask + flag all filter variables if any test variable is out of bounds: true + minvalue: 0.0 + maxvalue: 0.5 Thanks @HuiLiu-NOAA https://github.com/HuiLiu-NOAA for the input. For #⁠2, it seems like it worked for mesonet obs with the min/maxvalue indented under the filter and not under test variables. So maybe it works either way? — Reply to this email directly, view it on GitHub <#237 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOF252DUDNVLY2FAQU36BT32CX767AVCNFSM6AAAAABSRFFFXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRVGY2TCOBVHE . You are receiving this because you were mentioned.Message ID: @.**>

Thanks @HuiLiu-NOAA for your answer. I will test this again.