Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Czech language #397

Open
wants to merge 67 commits into
base: main
Choose a base branch
from
Open

Add Czech language #397

wants to merge 67 commits into from

Conversation

trendspotter
Copy link

✅ I have read the contributing file

Summary

Adding czech strings from Poedit and updating JSON files

adding cs
adding Čeština
add cs strings
add czech strings
remove some strings
modify czech strings
add Czech string
Add czech strings
Add czech strings
Add czech strings
Add czech string
Add czech strings
add czech strings
add czech strings
add cs strings
add cs strings
add cs strings
add cs strings
Copy link
Member

@PierreBresson PierreBresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for your PR :) Here are two things to be fix:

  • Missing translation file for NoEmission components
  • Remove comma at the end of json files (see comment)
  • Fix imports in resources.ts

Otherwise, looks good 👍

"PERMISSIONS_REQUEST_COMPONENT_CAMERA_TITLE": "Žádný přístup ke kameře",
"PERMISSIONS_REQUEST_COMPONENT_CAMERA_SUBTITLE": "Chcete-li tuto funkci používat, dejte aplikaci NMF.earth v nastavení telefonu přístup k fotoaparátu.",
"PERMISSIONS_REQUEST_COMPONENT_NOTIFICATION_TITLE": "Nemáte oprávnění odesílat upozornění",
"PERMISSIONS_REQUEST_COMPONENT_NOTIFICATION_SUBTITLE": "Chcete-li tuto funkci používat, dejte aplikaci NMF.earth oprávnění k zasílání upozornění v nastavení telefonu.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid json: you need to remove the comma at the end of all json files

@@ -130,6 +130,38 @@ const fr = {
...RecurringEmissions.fr,
};

const cs = {
...UI.cs,
...Calculation.cs,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculation, NoEmission, PermissionsRequest & OpenFoodFacts imports are invalid: you forgot to add to do the import in related index files : import cs from "./cs.json";

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh.. I'm a little lost. :( unfortunately I'm not very experienced in programming

remove comma at the end
fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants