Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nina-python-init.py mentioned in .gitignore #12

Open
frafra opened this issue Jul 17, 2024 · 3 comments
Open

nina-python-init.py mentioned in .gitignore #12

frafra opened this issue Jul 17, 2024 · 3 comments

Comments

@frafra
Copy link
Contributor

frafra commented Jul 17, 2024

nina-python-init.py

It would be better not having a line referring to such script in the resulting .gitignore file.

@frafra
Copy link
Contributor Author

frafra commented Jul 17, 2024

Here too:

"nina-python-init.py" = ["S603", "S607"]

@nicokant
Copy link
Collaborator

nicokant commented Aug 2, 2024

Disagree on the first one: when the template is generated the file is included, and the file itself setups git. To remove it from .gitignore we should never use git add . and then manually specify the files to add (but we don't know them all).

Disagree on the second one: same as #15, we should not include then and copy-paste for different templates? The root pyproject.toml requires those lines.

@frafra
Copy link
Contributor Author

frafra commented Aug 3, 2024

That file belongs to the template, not to the generated project: do we agree on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants