Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to support Windows Server 2008 #167

Open
fjh1997 opened this issue Aug 20, 2024 · 5 comments
Open

How to support Windows Server 2008 #167

fjh1997 opened this issue Aug 20, 2024 · 5 comments

Comments

@fjh1997
Copy link

fjh1997 commented Aug 20, 2024

C:\Windows\system32>ba.exe
ba.exe
fatal error: bcryptprimitives.dll not found
runtime: panic before malloc heap initialized

It seems golang version above 1.20 not support windows 7 or 2008,how to downgrade go to support it?

PS: Here’s my patch. I made these changes to the code and downgraded the versions of Golang (to 1.20) and gVisor(20230927004350-cbd86285d259) to make it work on Windows Server 2008. But how can we integrate this into the project? Maybe we could add a parameter to select the Windows version?
diff.patch.txt

@NHAS
Copy link
Owner

NHAS commented Aug 25, 2024

Did you build it with go version 1.20? Or just downgrade the module file to 1.20?

If you open a pull request I'd be happy to add this. Im just typically on a dev machine that has a newer version of go installed.

@NHAS NHAS added the enhancement New feature or request label Aug 25, 2024
@fjh1997
Copy link
Author

fjh1997 commented Aug 25, 2024

Did you build it with go version 1.20? Or just downgrade the module file to 1.20?

If you open a pull request I'd be happy to add this. Im just typically on a dev machine that has a newer version of go installed.

I used Go 1.20 to compile this client because the highest version of Go that supports Windows Server 2008 is Go 1.20. I haven't tried the newer versions of Go with downgraded module yet, but according to this issue , it might not work due to this commit in Go. I just found a method to patch for higher versions of Go: https://github.com/stunndard/golangwin7patch. I haven't tried it yet, but I think it's much more convenient than downgrading Go.

@NHAS
Copy link
Owner

NHAS commented Aug 25, 2024

Yeah definitely more convenient than downgrading. Its a shame that the patcher needs windows to run otherwise I'd just include it in the docker container and add a flag for building things to enable windows 7 support.

@NHAS NHAS pinned this issue Sep 28, 2024
@NHAS
Copy link
Owner

NHAS commented Sep 28, 2024

Im going to pin this issue and may turn it into a discussion later on as its good information.

@NHAS NHAS removed the enhancement New feature or request label Sep 28, 2024
@NHAS NHAS closed this as completed in 3347662 Nov 2, 2024
@NHAS
Copy link
Owner

NHAS commented Nov 2, 2024

Woops closed the wrong thing. Apologises

@NHAS NHAS reopened this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants