Respond to tony's updates #3
Conversation
benthecarman
force-pushed
the
tony-updates
branch
2 times, most recently
from
984f9b2
to
dda3e48
Compare
| version BIGINT NOT NULL, | ||
| created_date TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL, | ||
| updated_date TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL, | ||
| created_date TIMESTAMP DEFAULT '2023-07-13'::TIMESTAMP NOT NULL, |
There was a problem hiding this comment.
I'm confused by this. I don't like the idea of the SQL default being here to convert the timestamp. I'm also not really sure how this is supposed to play with the functions you created for setting timestamp. Is there not something built in for this? Why not do the manual timestamp default when inserting data that has None for the time?
There was a problem hiding this comment.
I think it'd be ideal if we can enforce the NOT NULL on these columns, wanted to have it set so rows we insert from the migration from the old db would get the launch date timestamp
benthecarman
force-pushed
the
tony-updates
branch
from
dda3e48
to
7592196
Compare
benthecarman
force-pushed
the
tony-updates
branch
from
7592196
to
45833ac
Compare
benthecarman
force-pushed
the
tony-updates
branch
2 times, most recently
from
24f7094
to
707313d
Compare
benthecarman
force-pushed
the
tony-updates
branch
from
707313d
to
9f09f65
Compare
src/models/migration_baseline.sql
Outdated
| @@ -0,0 +1,76 @@ | |||
| CREATE TABLE IF NOT EXISTS vss_db | |||
There was a problem hiding this comment.
not sure why this file is here since this is in the migrations folder.
There was a problem hiding this comment.
oh yeah meant to delete
|
How are migrations going to be handled going forward without diesel? Have you thought about a way to track that and deal with upgrades? |
We can do migrations with diesel and still have it not in the code, we can do it from the command line |
No description provided.