Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API should return errors for violation of key version constraints #10

Open
dienummer opened this issue Jan 21, 2024 · 1 comment
Open

Comments

@dienummer
Copy link
Contributor

I note the following deviations from the reference implementation's API contract/spec (https://github.com/lightningdevkit/vss-server/blob/main/app/src/main/proto/vss.proto) with respect to object PUTting

  1. put object succeeds even if newly created item does not have version: 0
  2. put object with lower version number than current should cause error (vss-rs accepts call and silently drops / does not update db)
  3. put object with version field increasing by > 1 is accepted
  4. missing delete_items field

I can tackle these; no promises on timeline

@benthecarman
Copy link
Contributor

We cannot do 3 as that'd break mutiny. 2 seems sound but could cause problems. Otherwise 1 and 4 seem fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants