Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue #42

Open
keunwoochoi opened this issue Aug 24, 2021 · 0 comments
Open

Performance issue #42

keunwoochoi opened this issue Aug 24, 2021 · 0 comments

Comments

@keunwoochoi
Copy link

(openjournals/joss-reviews#3391)

In the review checklist, we have this item

Functionality: Have the functional claims of the software been confirmed?
Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

On it, can you improve the doc regarding how models are supposed to perform? I ran a few files with omnizart music transcribe and realized for typical multi-instrument pop music, the performance might be under general expectation people would have.

Also, I found "music" to be a little too general. Shall we instead say it like "harmonic part", "tonal instruments", etc, and specify that the output would be a single-track midi file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant