Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usages of blacklist and whitelist #5275

Open
jdrueckert opened this issue Aug 18, 2024 · 5 comments · May be fixed by #5277
Open

Refactor usages of blacklist and whitelist #5275

jdrueckert opened this issue Aug 18, 2024 · 5 comments · May be fixed by #5277
Labels
Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity

Comments

@jdrueckert
Copy link
Member

Motivation

Whitelist and blacklist are nowadays referred to using the more inclusive terms allowlist and denylist (or blocklist).
Due to the age and size of our codebase, in older parts of the code we still use the less inclusive terms, e.g. in (ServerConnectListManager.java)[https://github.com/MovingBlocks/Terasology/blob/develop/engine/src/main/java/org/terasology/engine/network/internal/ServerConnectListManager.java]
We want to demonstrate our openness and inclusiveness not only in how we treat people but also in our code, so this should be changed.

Proposal

Search our codebase for usages of "whitelist" and "blacklist" and refactor these usages to "allowlist" and "denylist".

@jdrueckert jdrueckert added Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity labels Aug 18, 2024
@ppalanisami
Copy link

Hi, I am new to Open Source contribution and I would like to take this issue. Pls guide if u r ok with it

@Cervator
Copy link
Member

Hello @ppalanisami and welcome!

Since this issue was essentially just posted and has "Good First Issue" on it you absolutely can go ahead, and noting that on here can be helpful just for awareness - thank you! 👍

@fakegithub01
Copy link

hi @jdrueckert @Cervator i would like to work on this issue. Could you please assign this issue to me?

@Cervator
Copy link
Member

@fakegithub01 uh, interesting user name there, and now I'm starting to wonder if this issue is getting bot-attention, rather than any serious reading.

@jdrueckert
Copy link
Member Author

@fakegithub01 @ppalanisami please just feel free starting to work on this and open a PR with your changes
we don't assign issues to non-regulars by default to avoid issues being blocked for a long time when an assignee goes MIA, hope you can understand that. once you provided a PR, we can link it to this issue and assign you respectively.

byhlel added a commit to byhlel/Terasology that referenced this issue Sep 23, 2024
…t and blocklist

We want to demonstrate our openness and inclusiveness in our code

Resolves MovingBlocks#5275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
Status: No status
Status: No status
4 participants