Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More encouragement to upload all relevant log files rather than just one #22

Open
Cervator opened this issue Oct 11, 2015 · 3 comments
Open

Comments

@Cervator
Copy link
Member

Cervator commented Oct 11, 2015

We still occasionally have users that submit a log file but it'll turn out to be the wrong one. Probably the CR should either prompt the user in some fashion or or offer a way to combine/zip multiple logs into one package.

Ideally we should be able to link the listed error (like java.lang.IllegalStateException: Data is not an array) with the log file it came from and show that one to begin with. Then even if the user only uploads one file at least it'll be the most likely one to help. Other than when there's some error on startup that's involved, anyway.

I wonder if we could include GitHub Gists as an upload option? Since that is multi-file it would be a pretty sweet primary option (especially since pastebin seems to be broken / out of sync with the API / throttled / something)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27334528-more-encouragement-to-upload-all-relevant-log-files-rather-than-just-one?utm_campaign=plugin&utm_content=tracker%2F1626462&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1626462&utm_medium=issues&utm_source=github).
@msteiger
Copy link
Member

One option would be to revert the multiple file thing entirely and just dump all logging information in one file.

Another option would be to upload zip file containing all logs.

Maybe the easiest would be sorting the log files by timestamp (isn't that done already?) so that the one containing the crash would be the first entry.

@Cervator
Copy link
Member Author

Cervator commented Nov 2, 2015

Pretty sure timestamp isn't being respected (fully?). I had a test crash just the other day and got my world3 file served when a world4 file had the crash in it.

I know Logback can write to multiple files. We could always consider doing both? Have a unified file and split out files. Add a quick logging config section in-game if you just want one or want to customize.

But yeah it may be more complexity than it is worth. Still, new file(s) per launch for sure is nice, even unifying the log file types wouldn't "fix" that ultimately resulting in multiple files.

I think a few usability fixes will cover most bases. Being sure to clarify the actual crashed error and that the active log tab contains it. Offering a zip file option (to GDrive maybe?). Gist is nice for its multi-file approach, but I'm not sure what the API supports (uploading as Gooey but without granting access for the CR to use Gooey's account for anything else, and throttling any attempts to spam gists)

@Cervator
Copy link
Member Author

Simple suggestion: depending on the log upload service just cram each relevant file into one paste for something like pastebin :-)

Gist would be neat to just supply each file into its own sub-section.

Related: #26 (could be another snippet added to the top)

Edit: The pro account can now also handle bigger pastes (10mb instead of 500kb) so this should help with cramming multiple files together)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants