removed calls with default values

MorphiaOrg · Jun 21, 2024 · 84dc0f7 · 84dc0f7
1 parent 1bcfe44
commit 84dc0f7
Show file tree

Hide file tree

Showing 196 changed files with 665 additions and 1,235 deletions.
diff --git a/audits/src/main/kotlin/dev/morphia/audits/RstAuditor.kt b/audits/src/main/kotlin/dev/morphia/audits/RstAuditor.kt
@@ -251,7 +251,7 @@ class RstAuditor(val type: OperatorType) {
         } else {
             method.setBody(
                 """
-                    |testPipeline(new dev.morphia.test.util.ActionTestOptions().serverVersion(dev.morphia.test.ServerVersion.ANY).removeIds(false).orderMatters(true), aggregation -> aggregation
+                    |testPipeline(aggregation -> aggregation
                     |   .pipeline(
                     |
                     |)); """

diff --git a/core/src/test/java/dev/morphia/test/TemplatedTestBase.java b/core/src/test/java/dev/morphia/test/TemplatedTestBase.java
@@ -212,7 +212,7 @@ private Method isTestMethod(StackTraceElement element) {
     }
 
     public void testQuery(Function<Query<Document>, Query<Document>> function) {
-        testQuery(new ActionTestOptions(), function);
+        testQuery(function);
     }
 
     public void testQuery(ActionTestOptions options,
@@ -228,7 +228,7 @@ public void testQuery(ActionTestOptions options,
     }
 
     public void testUpdate(Function<Query<Document>, Query<Document>> function, UpdateOperator... operators) {
-        testUpdate(new ActionTestOptions(), function, operators);
+        testUpdate(function, operators);
     }
 
     public void testUpdate(ActionTestOptions options,

diff --git a/core/src/test/java/dev/morphia/test/TestTransactions.java b/core/src/test/java/dev/morphia/test/TestTransactions.java
@@ -168,7 +168,7 @@ public void merge() {
     public void aggregation() {
         getDs().withTransaction(session -> {
             testPipeline(
-                    new dev.morphia.test.util.ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(false),
+                    new dev.morphia.test.util.ActionTestOptions().orderMatters(false),
                     aggregation -> {
                         loadData("aggTest2", 2);
                         return aggregation

diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAbs.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAbs.java
@@ -17,9 +17,8 @@ public class TestAbs extends TemplatedTestBase {
      */
     @Test(testName = "main")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
-                aggregation -> aggregation
-                        .pipeline(project().include("delta", abs(subtract("$startTemp", "$endTemp")))));
+        testPipeline(new ActionTestOptions().serverVersion(ANY), aggregation -> aggregation
+                .pipeline(project().include("delta", abs(subtract("$startTemp", "$endTemp")))));
 
     }
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAccumulator.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAccumulator.java
@@ -18,8 +18,7 @@ public class TestAccumulator extends TemplatedTestBase {
      */
     @Test(testName = "Use ``$accumulator`` to Implement the ``$avg`` Operator")
     public void testExample1() {
-        testPipeline(
-                new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(false).skipActionCheck(true),
+        testPipeline(new ActionTestOptions().serverVersion(ANY).orderMatters(false).skipActionCheck(true),
                 aggregation -> aggregation.pipeline(Group.group(Group.id("$author")).field("avgCopies", accumulator("""
                         function() {
                           return { count: 0, sum: 0 }
@@ -48,8 +47,7 @@ public void testExample1() {
      */
     @Test(testName = "Use ``initArgs`` to Vary the Initial State by Group")
     public void testExample2() {
-        testPipeline(
-                new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(false).skipActionCheck(true),
+        testPipeline(new ActionTestOptions().serverVersion(ANY).orderMatters(false).skipActionCheck(true),
                 aggregation -> aggregation.pipeline(Group.group(Group.id().field("city", "$city")).field("restaurants",
                         accumulator("""
                                 function(city, userProfileCity) {       \s

diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAcos.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAcos.java
@@ -18,9 +18,8 @@ public class TestAcos extends TemplatedTestBase {
      */
     @Test(testName = "main :: Inverse Cosine of Value in Degrees")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
-                aggregation -> aggregation.pipeline(
-                        addFields().field("angle_a", radiansToDegrees(acos(divide("$side_b", "$hypotenuse"))))));
+        testPipeline(new ActionTestOptions().serverVersion(ANY), aggregation -> aggregation
+                .pipeline(addFields().field("angle_a", radiansToDegrees(acos(divide("$side_b", "$hypotenuse"))))));
 
     }
 
@@ -30,9 +29,8 @@ public void testExample1() {
      */
     @Test(testName = "main :: Inverse Cosine of Value in Radians")
     public void testExample2() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
-                aggregation -> aggregation
-                        .pipeline(addFields().field("angle_a", acos(divide("$side_b", "$hypotenuse")))));
+        testPipeline(new ActionTestOptions().serverVersion(ANY), aggregation -> aggregation
+                .pipeline(addFields().field("angle_a", acos(divide("$side_b", "$hypotenuse")))));
 
     }
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAcosh.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAcosh.java
@@ -17,9 +17,8 @@ public class TestAcosh extends TemplatedTestBase {
      */
     @Test(testName = "main :: Inverse Hyperbolic Cosine in Degrees")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
-                aggregation -> aggregation
-                        .pipeline(addFields().field("y-coordinate", radiansToDegrees(acosh("$x-coordinate")))));
+        testPipeline(new ActionTestOptions().serverVersion(ANY), aggregation -> aggregation
+                .pipeline(addFields().field("y-coordinate", radiansToDegrees(acosh("$x-coordinate")))));
 
     }
 
@@ -29,7 +28,7 @@ public void testExample1() {
      */
     @Test(testName = "main :: Inverse Hyperbolic Cosine in Radians")
     public void testExample2() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
+        testPipeline(new ActionTestOptions().serverVersion(ANY),
                 aggregation -> aggregation.pipeline(addFields().field("y-coordinate", acosh("$x-coordinate"))));
 
     }

diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAdd.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAdd.java
@@ -16,9 +16,8 @@ public class TestAdd extends TemplatedTestBase {
      */
     @Test(testName = "Add Numbers")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation
-                        .pipeline(project().include("item").include("total", add("$price", "$fee"))));
+        testPipeline(new ActionTestOptions().serverVersion(ANY), (aggregation) -> aggregation
+                .pipeline(project().include("item").include("total", add("$price", "$fee"))));
     }
 
     /**
@@ -27,9 +26,8 @@ public void testExample1() {
      */
     @Test(testName = "Perform Addition on a Date")
     public void testExample2() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
-                aggregation -> aggregation
-                        .pipeline(project().include("item", 1).include("billing_date", add("$date", 259200000))));
+        testPipeline(new ActionTestOptions().serverVersion(ANY), aggregation -> aggregation
+                .pipeline(project().include("item", 1).include("billing_date", add("$date", 259200000))));
 
     }
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAddToSet.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAddToSet.java
@@ -22,7 +22,7 @@ public class TestAddToSet extends TemplatedTestBase {
      */
     @Test(testName = "Use in ``$group`` Stage")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(false),
+        testPipeline(new ActionTestOptions().serverVersion(ANY).orderMatters(false),
                 aggregation -> aggregation
                         .pipeline(group(Group.id().field("day", dayOfYear("$date")).field("year", year("$date")))
                                 .field("itemsSold", addToSet("$item")))
@@ -39,7 +39,7 @@ public void testExample1() {
     public void testExample2() {
         if (1 == 1)
             return;
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(false),
+        testPipeline(new ActionTestOptions().serverVersion(ANY).orderMatters(false),
                 aggregation -> aggregation.setWindowFields(setWindowFields().partitionBy("$state")
                         .sortBy(ascending("orderDate")).output(output("cakeTypesForState").operator(addToSet("$type"))
                                 .window().documents("unbounded", "current"))));

diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAllElementsTrue.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAllElementsTrue.java
@@ -16,7 +16,7 @@ public class TestAllElementsTrue extends TemplatedTestBase {
      */
     @Test(testName = "main")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(false),
+        testPipeline(new ActionTestOptions().serverVersion(ANY).orderMatters(false),
                 aggregation -> aggregation.pipeline(Projection.project().suppressId().include("responses")
                         .include("isAllTrue", allElementsTrue("$responses"))));
 

diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAnd.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAnd.java
@@ -18,9 +18,8 @@ public class TestAnd extends TemplatedTestBase {
      */
     @Test(testName = "main")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
-                aggregation -> aggregation.pipeline(project().include("item").include("qty").include("result",
-                        and(gt("$qty", 100), lt("$qty", 250)))));
+        testPipeline(new ActionTestOptions().serverVersion(ANY), aggregation -> aggregation.pipeline(
+                project().include("item").include("qty").include("result", and(gt("$qty", 100), lt("$qty", 250)))));
 
     }
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAnyElementTrue.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAnyElementTrue.java
@@ -16,9 +16,8 @@ public class TestAnyElementTrue extends TemplatedTestBase {
      */
     @Test(testName = "main")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ANY).removeIds(false).orderMatters(true),
-                aggregation -> aggregation.pipeline(project().suppressId().include("responses").include("isAnyTrue",
-                        anyElementTrue("$responses"))));
+        testPipeline(new ActionTestOptions().serverVersion(ANY), aggregation -> aggregation.pipeline(
+                project().suppressId().include("responses").include("isAnyTrue", anyElementTrue("$responses"))));
 
     }
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestArrayElemAt.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestArrayElemAt.java
@@ -1,8 +1,6 @@
 package dev.morphia.test.aggregation.expressions;
 
-import dev.morphia.test.ServerVersion;
 import dev.morphia.test.TemplatedTestBase;
-import dev.morphia.test.util.ActionTestOptions;
 
 import org.testng.annotations.Test;
 
@@ -16,8 +14,7 @@ public class TestArrayElemAt extends TemplatedTestBase {
      */
     @Test(testName = "main")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation.pipeline(project().include("name")
-                        .include("first", elementAt("$favorites", 0)).include("last", elementAt("$favorites", -1))));
+        testPipeline((aggregation) -> aggregation.pipeline(project().include("name")
+                .include("first", elementAt("$favorites", 0)).include("last", elementAt("$favorites", -1))));
     }
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestArrayToObject.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestArrayToObject.java
@@ -1,8 +1,6 @@
 package dev.morphia.test.aggregation.expressions;
 
-import dev.morphia.test.ServerVersion;
 import dev.morphia.test.TemplatedTestBase;
-import dev.morphia.test.util.ActionTestOptions;
 
 import org.testng.annotations.Test;
 
@@ -22,9 +20,8 @@ public class TestArrayToObject extends TemplatedTestBase {
      */
     @Test(testName = "``$arrayToObject``  Example")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation
-                        .pipeline(project().include("item").include("dimensions", arrayToObject("$dimensions"))));
+        testPipeline((aggregation) -> aggregation
+                .pipeline(project().include("item").include("dimensions", arrayToObject("$dimensions"))));
     }
 
     /**
@@ -33,12 +30,10 @@ public void testExample1() {
      */
     @Test(testName = "``$objectToArray`` + ``$arrayToObject`` Example")
     public void testExample2() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation.pipeline(addFields().field("instock", objectToArray("$instock")),
-                        addFields().field("instock",
-                                concatArrays("$instock",
-                                        array(document().field("k", "total").field("v", sum("$instock.v"))))),
-                        addFields().field("instock", arrayToObject("$instock"))));
+        testPipeline((aggregation) -> aggregation.pipeline(addFields().field("instock", objectToArray("$instock")),
+                addFields().field("instock",
+                        concatArrays("$instock", array(document().field("k", "total").field("v", sum("$instock.v"))))),
+                addFields().field("instock", arrayToObject("$instock"))));
     }
 
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAsin.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAsin.java
@@ -1,8 +1,6 @@
 package dev.morphia.test.aggregation.expressions;
 
-import dev.morphia.test.ServerVersion;
 import dev.morphia.test.TemplatedTestBase;
-import dev.morphia.test.util.ActionTestOptions;
 
 import org.testng.annotations.Test;
 
@@ -18,9 +16,8 @@ public class TestAsin extends TemplatedTestBase {
      */
     @Test(testName = "main :: Inverse Sine of Value in Degrees")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation.pipeline(
-                        addFields().field("angle_a", radiansToDegrees(asin(divide("$side_a", "$hypotenuse"))))));
+        testPipeline((aggregation) -> aggregation
+                .pipeline(addFields().field("angle_a", radiansToDegrees(asin(divide("$side_a", "$hypotenuse"))))));
     }
 
     /**
@@ -29,9 +26,8 @@ public void testExample1() {
      */
     @Test(testName = "main :: Inverse Sine of Value in Radians")
     public void testExample2() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation
-                        .pipeline(addFields().field("angle_a", asin(divide("$side_a", "$hypotenuse")))));
+        testPipeline((aggregation) -> aggregation
+                .pipeline(addFields().field("angle_a", asin(divide("$side_a", "$hypotenuse")))));
     }
 
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAsinh.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAsinh.java
@@ -1,8 +1,6 @@
 package dev.morphia.test.aggregation.expressions;
 
-import dev.morphia.test.ServerVersion;
 import dev.morphia.test.TemplatedTestBase;
-import dev.morphia.test.util.ActionTestOptions;
 
 import org.testng.annotations.Test;
 
@@ -17,9 +15,8 @@ public class TestAsinh extends TemplatedTestBase {
      */
     @Test(testName = "main :: Inverse Hyperbolic Sine in Degrees")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation
-                        .pipeline(addFields().field("y-coordinate", radiansToDegrees(asinh("$x-coordinate")))));
+        testPipeline((aggregation) -> aggregation
+                .pipeline(addFields().field("y-coordinate", radiansToDegrees(asinh("$x-coordinate")))));
     }
 
     /**
@@ -28,8 +25,7 @@ public void testExample1() {
      */
     @Test(testName = "main :: Inverse Hyperbolic Sine in Radians")
     public void testExample2() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation.pipeline(addFields().field("y-coordinate", asinh("$x-coordinate"))));
+        testPipeline((aggregation) -> aggregation.pipeline(addFields().field("y-coordinate", asinh("$x-coordinate"))));
     }
 
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAtan.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAtan.java
@@ -1,8 +1,6 @@
 package dev.morphia.test.aggregation.expressions;
 
-import dev.morphia.test.ServerVersion;
 import dev.morphia.test.TemplatedTestBase;
-import dev.morphia.test.util.ActionTestOptions;
 
 import org.testng.annotations.Test;
 
@@ -18,9 +16,8 @@ public class TestAtan extends TemplatedTestBase {
      */
     @Test(testName = "main :: Inverse Tangent of Value in Degrees")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation
-                        .pipeline(addFields().field("angle_a", radiansToDegrees(atan(divide("$side_b", "$side_a"))))));
+        testPipeline((aggregation) -> aggregation
+                .pipeline(addFields().field("angle_a", radiansToDegrees(atan(divide("$side_b", "$side_a"))))));
     }
 
     /**
@@ -29,9 +26,8 @@ public void testExample1() {
      */
     @Test(testName = "main :: Inverse Tangent of Value in Radians")
     public void testExample2() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation
-                        .pipeline(addFields().field("angle_a", atan(divide("$side_b", "$side_a")))));
+        testPipeline((aggregation) -> aggregation
+                .pipeline(addFields().field("angle_a", atan(divide("$side_b", "$side_a")))));
     }
 
 }
diff --git a/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAtan2.java b/core/src/test/java/dev/morphia/test/aggregation/expressions/TestAtan2.java
@@ -1,8 +1,6 @@
 package dev.morphia.test.aggregation.expressions;
 
-import dev.morphia.test.ServerVersion;
 import dev.morphia.test.TemplatedTestBase;
-import dev.morphia.test.util.ActionTestOptions;
 
 import org.testng.annotations.Test;
 
@@ -17,9 +15,8 @@ public class TestAtan2 extends TemplatedTestBase {
      */
     @Test(testName = "main :: Inverse Tangent of Value in Degrees")
     public void testExample1() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation
-                        .pipeline(addFields().field("angle_a", radiansToDegrees(atan2("$side_b", "$side_a")))));
+        testPipeline((aggregation) -> aggregation
+                .pipeline(addFields().field("angle_a", radiansToDegrees(atan2("$side_b", "$side_a")))));
     }
 
     /**
@@ -28,8 +25,7 @@ public void testExample1() {
      */
     @Test(testName = "main :: Inverse Tangent of Value in Radians")
     public void testExample2() {
-        testPipeline(new ActionTestOptions().serverVersion(ServerVersion.ANY).removeIds(false).orderMatters(true),
-                (aggregation) -> aggregation.pipeline(addFields().field("angle_a", atan2("$side_b", "$side_a"))));
+        testPipeline((aggregation) -> aggregation.pipeline(addFields().field("angle_a", atan2("$side_b", "$side_a"))));
     }
 
 }