fix: correct field name in missing_recommended_field_notice (#1574) (#…

…1706)
MobilityData · Mar 12, 2024 · dee5802 · dee5802
1 parent f91e524
commit dee5802
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/AgencyConsistencyValidator.java b/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/AgencyConsistencyValidator.java
@@ -62,7 +62,9 @@ public void validate(NoticeContainer noticeContainer) {
       if (!agency.hasAgencyId()) {
         noticeContainer.addValidationNotice(
             new MissingRecommendedFieldNotice(
-                agencyTable.gtfsFilename(), agency.csvRowNumber(), agency.agencyName()));
+                agencyTable.gtfsFilename(),
+                agency.csvRowNumber(),
+                GtfsAgency.AGENCY_ID_FIELD_NAME));
       }
       // no further validation required
       return;

diff --git a/...rc/test/java/org/mobilitydata/gtfsvalidator/validator/AgencyConsistencyValidatorTest.java b/...rc/test/java/org/mobilitydata/gtfsvalidator/validator/AgencyConsistencyValidatorTest.java
@@ -72,7 +72,9 @@ public void singleAgencyPresentButNoAgencyIdSetShouldGenerateWarningNotice() {
                     ZoneId.of("America/Montreal"),
                     Locale.CANADA)));
     assertThat(notices)
-        .containsExactly(new MissingRecommendedFieldNotice("agency.txt", 0, "agency name"));
+        .containsExactly(
+            new MissingRecommendedFieldNotice(
+                GtfsAgency.FILENAME, 0, GtfsAgency.AGENCY_ID_FIELD_NAME));
   }
 
   @Test
@@ -95,7 +97,9 @@ public void multipleAgenciesPresentButNoAgencyIdSetShouldGenerateErrorNotice() {
                     ZoneId.of("America/Montreal"),
                     Locale.CANADA)));
     assertThat(notices)
-        .containsExactly(new MissingRequiredFieldNotice("agency.txt", 1, "agency_id"));
+        .containsExactly(
+            new MissingRequiredFieldNotice(
+                GtfsAgency.FILENAME, 1, GtfsAgency.AGENCY_ID_FIELD_NAME));
   }
 
   @Test