Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload commission is calculated incorrectly on the Send screen #1

Open
norlin opened this issue Mar 5, 2021 · 0 comments
Open

Payload commission is calculated incorrectly on the Send screen #1

norlin opened this issue Mar 5, 2021 · 0 comments

Comments

@norlin
Copy link

norlin commented Mar 5, 2021

At this line, the payload comission is calculated incorrectly, thus after the transaction is send, a node tries to withdraw different ammount (significantly larger) and the transaction may fail here if there is no funds.

Test case:

  1. Make a new wallet (0 BIPs balance)
  2. Send a transaction with 0 BIP and some payload: Test payload
  3. The app shows Transaction Fee as 1.0240
  4. Send the transaction
  5. Get an error about insufficient funds with required sum 3.4 BIP (instead of 1.0240 as expected)

Possible solutions:

  1. Request the transaction fee from node
  2. Duplicate payload fees calculation logic from the node's code
@norlin norlin changed the title payload commission is calculated incorrectly Payload commission is calculated incorrectly on the Send screen Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant