Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find the cause of click sound on key on #1

Open
MiklosPathy opened this issue Feb 11, 2018 · 2 comments
Open

Find the cause of click sound on key on #1

MiklosPathy opened this issue Feb 11, 2018 · 2 comments

Comments

@MiklosPathy
Copy link
Owner

As the title.
@MiklosPathy
Copy link
Owner Author

Cause: the sine wave phase is not 0 at key on.
Solution: reset the phase at key on.
The problem still will exist at key off, so it needs a timer to run out the phase to 0. Or a volume envelope, but in PunkOrgan the phase it already there, maybe it is easier to play with that.

@MiklosPathy
Copy link
Owner Author

Phase reset and out is ready. Better, but envelope should be better. Later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MiklosPathy