Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maui] Update Native Library Interop docs for net9.0 #487

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

pjcollins
Copy link
Contributor

Updates the Maui.NativeLibraryInterop docs to mention the new build
items available in the .NET for Android, iOS, Mac Catalyst, macOS, and
tvOS SDKs.

Updates the Maui.NativeLibraryInterop docs to mention the new build
items available in the .NET for Android, iOS, Mac Catalyst, macOS, and
tvOS SDKs.
Copy link

Learn Build status updates of commit 544ee5d:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/native-library-interop/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit b49af9d:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ⚠️Warning View Details
docs/maui/native-library-interop/index.md ✅Succeeded View

docs/maui/native-library-interop/get-started.md

  • Line 127, Column 46: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/dotnet/android/binding-libs/advanced-concepts/resolving-java-dependencies' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 127, Column 46: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/dotnet/android/binding-libs/advanced-concepts/resolving-java-dependencies' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 74ee0f0:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ⚠️Warning View Details
docs/maui/native-library-interop/index.md ✅Succeeded View

docs/maui/native-library-interop/get-started.md

  • Line 124, Column 50: [Warning: file-not-found - See documentation] Invalid file link: 'dotnet/android/binding-libs/advanced-concepts/android-maven-library'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 2f092a3:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ✅Succeeded View
docs/maui/native-library-interop/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions based on our conversations!

docs/maui/native-library-interop/get-started.md Outdated Show resolved Hide resolved
docs/maui/native-library-interop/get-started.md Outdated Show resolved Hide resolved
docs/maui/native-library-interop/get-started.md Outdated Show resolved Hide resolved
docs/maui/native-library-interop/get-started.md Outdated Show resolved Hide resolved
docs/maui/native-library-interop/get-started.md Outdated Show resolved Hide resolved
docs/maui/native-library-interop/index.md Outdated Show resolved Hide resolved
pjcollins and others added 2 commits November 11, 2024 14:46
Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
Copy link

Learn Build status updates of commit 2ae238b:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ✅Succeeded View
docs/maui/native-library-interop/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

pjcollins and others added 2 commits November 11, 2024 14:48
Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
Copy link

Learn Build status updates of commit 26002a7:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ✅Succeeded View
docs/maui/native-library-interop/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
Copy link

Learn Build status updates of commit 9bde113:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ✅Succeeded View
docs/maui/native-library-interop/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 8947f74:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ✅Succeeded View
docs/maui/native-library-interop/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit f4ea74f:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ⚠️Warning View Details
docs/maui/native-library-interop/index.md ✅Succeeded View

docs/maui/native-library-interop/get-started.md

  • Line 106, Column 14: [Warning: file-not-found - See documentation] Invalid file link: 'previous-versions/xamarin/cross-platform/macios/binding/objective-sharpie/tools'.
  • Line 126, Column 120: [Warning: file-not-found - See documentation] Invalid file link: 'dotnet/android/binding-libs/advanced-concepts/java-dependency-verification'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 2043537:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ✅Succeeded View
docs/maui/native-library-interop/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@pjcollins pjcollins marked this pull request as ready for review November 14, 2024 19:25
Copy link

Learn Build status updates of commit 4d999e4:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/native-library-interop/get-started.md ✅Succeeded View
docs/maui/native-library-interop/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants