-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.2 release #358
Comments
@da314pc Regarding first point, meteor needs to make changes in the build process, that is not something I believe we (as a plugin) should touch, we can create an issue in the meteor and update our docs for the time being.
Also, let's start closing the issues that are already fixed. |
|
Cool 👍 |
Regarding 1st Comment. I was able to make the notification work for Oreo using FCM without using build-extras.gradle. I suspect it works when you move to 1.8.0.2. I am using phonegap-plugin-push@2.1.3. |
meteor/meteor#7600 (comment) |
@pkumar-uk did you use build-extras.gradle configuration: @shivang007 I think for now maybe we just update the readme until we have tested the build extras build. Everyone isn't on 1.8, im still using 1.6, But I will create a pull request probably within the next day to get the android channel changes. |
No, I did not use build-extras.gradle configuration as mentioned in meteor/meteor#7600 (comment) |
@shivang007 @aboire I have just created the Pull Request for the android channel Integration, I have added you as a reviewer. After that is merged in I will update the README docs on the instructions. |
@da314pc update the README docs in this request only, it will be easier to track. |
@shivang007 great suggestion, I updated the readme in the pull request. You can review. |
@shivang007 could you take a look at the update changes. |
@da314pc I was able to build the app by following the steps in your readme, so that solves the build problem. I will make sure to get an android 8 and test it by tomorrow. Meanwhile can you please make the other changes in the pull request, you have indented the file and hence it's showing extra code which is not going in this release. Just make sure that the files shows only those changes that you have made and we will move ahead with the merge. |
@shivang007 Thanks for helping getting the android 8 merged in. Now we can look at the FCM and new APN update pull request. Just let me know which ones you prefer to work on and I'll take a look at the other one |
@da314pc I can look at the FCM. |
Hi, you can find documentation and latest updates of everything in this repo: https://github.com/activitree/meteor-push this is up to date with all libraries and running in production. Perhaps this could help you to get the FCM up to date (which is not really the "standard") and you might want to use the Firebase-Admin instead. You might also want to consider to start pushing to that repo too, given the fact that it is already based on far more recent tech. |
@shivang007 For this release I think we should get the following issues updated:
Notifications to Android 8.0+ are blocked because notification channels are required #341 (comment)
I have found the fix, we need to investigate if we can update the build.gradle with the correct firebase
libraries
Test & Merge in these two pull request's
WIP: upgrade to apn v2.2.0 and removed config plugin #327
Add FCM Firebase Cloud Messaging support #354
Update the Readme: https://github.com/ToothlessGear/node-gcm already supports FCM, so there is confusion among some users
Mass removal of tokens in Meteor 1.7 #342
Anyone got this working with the new Apple p8 files #326
The text was updated successfully, but these errors were encountered: