Add climatology features #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging we will need to update the workflow to ensure this works |
|
@dnerini could you have a look at the code in its current state ? I moved the calculation of the rolling mean to mlpp-features, as discussed. |
…or that day window
louisPoulain
commented
Nov 27, 2024
Comment on lines
+275
to
+312
| @pytest.fixture | ||
| def clim_dataset(): | ||
| """Create climatology dataset as if loaded from zarr files, still unprocessed.""" | ||
|
|
||
| def _data(): | ||
|
|
||
| variables = [ | ||
| "cloud_area_fraction", | ||
| ] | ||
|
|
||
| stations = _stations_dataframe() | ||
| times = pd.date_range("2000-01-01T00", "2000-01-02T00", freq="1h") | ||
|
|
||
| n_times = len(times) | ||
| n_stations = len(stations) | ||
|
|
||
| var_shape = (n_times, n_stations) | ||
| ds = xr.Dataset( | ||
| None, | ||
| coords={ | ||
| "time": times, | ||
| "station": stations.index, | ||
| "longitude": ("station", stations.longitude), | ||
| "latitude": ("station", stations.latitude), | ||
| "height_masl": ("station", stations.height_masl), | ||
| "owner_id": ("station", np.random.randint(1, 5, stations.shape[0])), | ||
| "pole_height": ("station", np.random.randint(5, 15, stations.shape[0])), | ||
| "roof_height": ("station", np.zeros(stations.shape[0])), | ||
| }, | ||
| ) | ||
| for var in variables: | ||
| measurements = np.random.randn(*var_shape) | ||
| nan_idx = [np.random.randint(0, d, 60) for d in var_shape] | ||
| measurements[nan_idx[0], nan_idx[1]] = np.nan | ||
| ds[var] = (("time", "station"), measurements) | ||
| return ds | ||
|
|
||
| return _data |
There was a problem hiding this comment.
If we move to using the "obs" part of the variable dictionnary, we likely don't need this anymore
louisPoulain
commented
Nov 27, 2024
Comment on lines
+331
to
+344
| try: | ||
| rolling_mean_day = ( | ||
| rolling_mean_hour.where( | ||
| rolling_mean_hour["dayofyear"].isin(days_range), drop=True | ||
| ) | ||
| .groupby("time.hour") | ||
| .mean() | ||
| ) | ||
| except ValueError as e: | ||
| if "hour must not be empty" in str(e): | ||
| days_list.remove(day) | ||
| continue | ||
| else: | ||
| raise e |
There was a problem hiding this comment.
Sort of fix to pass the pytest.
It fails (without that fix) if one the days window is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.