Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry pick ledger confirm button fix into 12.3.0 #27342

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Sep 23, 2024

Description

This PR cherry-picks #27331

Open in GitHub Codespaces

Related issues

#27331

Manual testing steps

Tested and approved by QA in original PR

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… `Ledger` with the new redesign (#27331)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR fixes the issue where confirm button is always disabled when
contract interactions with Ledger account

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27331?quickstart=1)

Fixes: #27240

1. Activate Ledger account in MM
2. Go to uniswap
3. Try swapping from Sepolia eth to Weth
4. See confirmation "Confirm" button is not disabled

https://github.com/user-attachments/assets/aba4e44c-049e-4d64-b14a-9bdc4c25a9cb

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@OGPoyraz OGPoyraz requested a review from a team as a code owner September 23, 2024 15:24
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (439f7d6) to head (4411813).
Report is 19 commits behind head on Version-v12.3.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27342      +/-   ##
===================================================
- Coverage            70.24%   70.14%   -0.11%     
===================================================
  Files                 1426     1432       +6     
  Lines                50239    50428     +189     
  Branches             13954    13990      +36     
===================================================
+ Hits                 35289    35368      +79     
- Misses               14950    15060     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4411813]
Page Load Metrics (1951 ± 196 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21124501761440211
domContentLoaded156834651904399192
load158234751951408196
domInteractive13156433115

@danjm danjm merged commit 080fd23 into Version-v12.3.0 Sep 23, 2024
75 of 76 checks passed
@danjm danjm deleted the cherry-pick-12.3.0-fix-ledger-confirm-button branch September 23, 2024 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Sep 23, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.3.0 on PR, as PR was cherry-picked in branch 12.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants