-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cherry pick ledger confirm button fix into 12.3.0
#27342
Merged
danjm
merged 1 commit into
Version-v12.3.0
from
cherry-pick-12.3.0-fix-ledger-confirm-button
Sep 23, 2024
Merged
fix: cherry pick ledger confirm button fix into 12.3.0
#27342
danjm
merged 1 commit into
Version-v12.3.0
from
cherry-pick-12.3.0-fix-ledger-confirm-button
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `Ledger` with the new redesign (#27331) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fixes the issue where confirm button is always disabled when contract interactions with Ledger account [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27331?quickstart=1) Fixes: #27240 1. Activate Ledger account in MM 2. Go to uniswap 3. Try swapping from Sepolia eth to Weth 4. See confirmation "Confirm" button is not disabled https://github.com/user-attachments/assets/aba4e44c-049e-4d64-b14a-9bdc4c25a9cb <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
vinistevam
approved these changes
Sep 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.3.0 #27342 +/- ##
===================================================
- Coverage 70.24% 70.14% -0.11%
===================================================
Files 1426 1432 +6
Lines 50239 50428 +189
Branches 13954 13990 +36
===================================================
+ Hits 35289 35368 +79
- Misses 14950 15060 +110 ☔ View full report in Codecov by Sentry. |
Builds ready [4411813]
Page Load Metrics (1951 ± 196 ms)
|
metamaskbot
added
the
release-12.3.0
Issue or pull request that will be included in release 12.3.0
label
Sep 23, 2024
No release label on PR. Adding release label release-12.3.0 on PR, as PR was cherry-picked in branch 12.3.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks #27331
Related issues
#27331
Manual testing steps
Tested and approved by QA in original PR
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist