Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define one_rmst() and diff_rmst() outside of rmst_multiple() #191

Closed
nanxstats opened this issue Feb 5, 2024 · 0 comments · Fixed by #192
Closed

Define one_rmst() and diff_rmst() outside of rmst_multiple() #191

nanxstats opened this issue Feb 5, 2024 · 0 comments · Fixed by #192
Assignees
@jdblischak
Labels
numerical performance

Comments

@nanxstats
Copy link
Collaborator

nanxstats commented Feb 5, 2024 •
edited
Loading

one_rmst() and diff_rmst() are internal functions currently defined inline, within rmst_multiple().

Following engineering best practices, it is advisable to define them outside of rmst_multiple().

Similar to #106.

The current implementation was added in #188.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdblischak jdblischak

Labels
numerical performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define one_rmst() and diff_rmst() outside of rmst_multiple() jdblischak/simtrial
2 participants
@nanxstats @jdblischak