fix: Handle reserved words in db, schema and table names #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
dialect_normalize_name
branch
11 times, most recently
from
10a4ceb
to
fd60bb1
Compare
…rmalize_name` dialect helper Co-authored-by: Pat Nadolny <patnadolny@gmail.com>
edgarrmondragon
force-pushed
the
dialect_normalize_name
branch
from
fd60bb1
to
df5d707
Compare
This was referenced Aug 13, 2024
pnadolny13
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
@edgarrmondragon I know this is in draft still but this looks like a good approach to me and with the addition of the new passing tests it seems safe to merge whenever youre ready.
edgarrmondragon
changed the title
normalize_name dialect helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
SQL compilation error...unexpected '.'when table name isORDER#230