Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joins with Nulls #44

Closed
visch opened this issue Jun 6, 2023 · 1 comment
Closed

Joins with Nulls #44

visch opened this issue Jun 6, 2023 · 1 comment

Comments

@visch
Copy link
Member

visch commented Jun 6, 2023

https://github.com/MeltanoLabs/target-snowflake/blob/main/target_snowflake/sinks.py#L248

@kgpayne

Instead of table.name = othertable.name try table.name IS DISTINCT FROM othertable.name 3 valued logic is fun!
@pnadolny13
Copy link
Contributor

This should have been resolved by these PRs:

Reserved words and casing shouldnt affect the comparisons anymore. I'm going to close this for now but if someone runs into this again please reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@visch @pnadolny13