refactor!: convert overhaul #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring users to convert by going from
BeatmaptoConverted, prior conversion is now optional. This causes all attribute calculations to be fallible! Whenever a calculation requires a beatmap to be converted but the conversion fails, it will result in an error. TheConvertedtype has been removed entirely but gamemode marker types are still available to be used with methods on theDifficultytype.The motivation for this change is that conversion generally also requires mods as a parameter (due to mania's Key mods). The previous api was fairly convoluted in terms of conversion functions and would've been even worse with mode-inclusion.