Fix SRID not being optional for expression in GeometryCast

[nickknissen]

The current implementation of GeometryCast requires SRID to present in the expression when setting an model attribute with DB:raw

The given case:

$place = Place::factory()->create(['point' => DB::raw("ST_GeomFromText('POINT(12.38057 55.73406)')")]);
$place->isDirty()

This will throw the following error because the regex looks for a SRID in the expressionValue

  Undefined array key 1

  at src\GeometryCast.php:86
     82▕         $expressionValue = $expression->getValue($grammar);
     83▕ 
     84▕         preg_match('/ST_GeomFromText\(\'(.+)\', .+(, .+)?\)/', (string) $expressionValue, $match);
     85▕ 
  ➜ 86▕         return $match[1];
     87▕     }
     88▕ 
     89▕     private function extractSridFromExpression(ExpressionContract $expression, Connection $connection): int
     90▕     {

The ST_GeomFromText specifications allows SRID not to be specified as seen in mysql and PostGis documentation:

• Mysql
• PostGIS

I have adjusted GeometryCast regex treat SRID as an optional parameter and return 0 when SRID is not defined.

[MatanYadaev]

@nickknissen Hi, thanks for the PR, I'll review it later.
What issue does it solve? Can you add tests to indicate the issue is solved?

[nickknissen]

@MatanYadaev
Currently ST_GeomFromText('POINT(9.581389 55.724167)') is not supported as an expression value. SRID is required.

I will add some tests.

[nickknissen]

@MatanYadaev I have updated the description with some more information about the error and added tests

[MatanYadaev]

Can you please resolve conflicts and fix CI?

[nickknissen]

Can you please resolve conflicts and fix CI?

It should be up to date now.

[MatanYadaev]

Thanks!