Support subject alternative URIs when generating cryptographic certificates. #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #340.
Note: In its current form, this PR breaks current behavior by requiring a new argument for cryptographic functions. How would Sprig maintainers prefer this be adjusted, if at all?
For convenience and reference, I'll include a snippet of #340 here:
Cryptographic Sprig functions (e.g.,
genSelfSignedCert
,genSelfSignedCertWithKey
, etc.) currently support clients passing in optional lists of IPs and alternate DNS names.I propose that these same cryptographic functions may also support clients passing in subject alternative URIs.
The crypto x509 package's
Certificate
(which Sprig relies on) supports specifying URI subject alternative names, as written in RFC5280:URIs are essential to the SPIFFE standard, where: