Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message-web text format #596

Open
therealryan opened this issue Oct 25, 2023 · 5 comments
Open

Improve message-web text format #596

therealryan opened this issue Oct 25, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code

Comments

@therealryan
Copy link
Collaborator

therealryan commented Oct 25, 2023

message-web's treatment of multiline values leaves a little something to be desired - it's good that it indents them, but in the result (for example) it's difficult to spot where the padding ends and the content begins.

We should improve the output to make it more obvious (perhaps?).

@therealryan therealryan added enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code labels Oct 25, 2023
@Arian-Ott
Copy link

Hi, you are right. I will have a look into this. Also this is my first issue so I am kinda excited to help :D

Cheers

@Arian-Ott
Copy link

Btw, what output do you exactly suggest?

@therealryan
Copy link
Collaborator Author

therealryan commented Oct 25, 2023

I think it'd probably be enough to put characters at the right-hand side of the padding. That should make it more obvious where the content begins

@therealryan
Copy link
Collaborator Author

therealryan commented Oct 25, 2023

If you were feeling especially fancy, you could put a on the last line of multiline content to make the distinction from the next value clearer

@therealryan
Copy link
Collaborator Author

Give me a shout if you need any help getting the project set up and building. As you won't be changing the angular app you can avoid having to install node if you want (just build with, e.g.: mvn test -Dnode=none.
This test will show the impact of your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code
Projects
None yet
Development

No branches or pull requests

2 participants