Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible doc error #193

Open
lgnbhl opened this issue Jun 28, 2022 · 1 comment
Open

possible doc error #193

lgnbhl opened this issue Jun 28, 2022 · 1 comment

Comments

@lgnbhl
Copy link

lgnbhl commented Jun 28, 2022

Hello,
There is a possible typo in the documentation of the cloudrunner section "Private Cloud Run service scheduling": https://code.markedmondson.me/googleCloudRunner/articles/cloudrun.html#private-cloud-run-service-scheduling

Shouldn't it be allowUnauthenticated = FALSE? What your wrote instead is:

# deploy a non-public app
cr_deploy_run("your-cloud-run", allowUnauthenticated = TRUE)

Thanks again for this great package!
Best,
Felix
@MarkEdmondson1234
Copy link
Owner

Yes you are right! Thanks

lgnbhl added a commit to lgnbhl/googleCloudRunner that referenced this issue Oct 17, 2023
@lgnbhl
fix doc error MarkEdmondson1234#193
98caa6d 
Fix documentation error as mentioned here MarkEdmondson1234#193
@lgnbhl lgnbhl mentioned this issue Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkEdmondson1234 @lgnbhl