Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: support MacOS and Linux #2

Open
JamesDunne opened this issue Jun 11, 2020 · 1 comment
Open

Suggestion: support MacOS and Linux #2

JamesDunne opened this issue Jun 11, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@JamesDunne
Copy link

Just a suggestion: could you change this to support MacOS and Linux platforms?

Vanilla bsnes compiles and runs on MacOS and Linux but your modifications appear to be Windows specific. I wanted to merge this integer scaling idea into my own fork of bsnes but all the Windows-specific code put a damper on that: it wouldn't compile on my main MacOS development machine. For my bsnes fork I maintain the cross-platform support of vanilla bsnes and offer continuous builds for all supported platforms.

If all of that is too much to ask, then may I ask if it is okay if I just implement your main integer scaling algorithm in my own bsnes fork?

@Marat-Tanalin
Copy link
Owner

Hello, James. Of course, feel free to implement integer scaling with my platform-agnostic IntegerScaling library. bsnes-mt uses this library under the hood.

Aside from integer scaling, I’m considering making bsnes-mt code more cross-platform — probably by using preprocessor conditions for using my Windows-specific code (including PNG support) for Windows builds, and the original bsnes code (including using BMP instead of PNG) for non-Windows builds. But for now I’m not interested in supporting non-Windows. Developing for masOS is basically not possible for me given that I don’t have, don’t need and don’t plan to buy a Mac, and I wouldn’t like to use Hackintosh. The Windows build may potentially work in Linux as is via Wine.

@Marat-Tanalin Marat-Tanalin added the enhancement New feature or request label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants