Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of FDR correction #257

Open
pejota66 opened this issue Oct 2, 2023 · 1 comment
Open

Type of FDR correction #257

pejota66 opened this issue Oct 2, 2023 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation next release This is something we have already addressed on a branch or will address before the next release.

Comments

@pejota66
Copy link

pejota66 commented Oct 2, 2023

What are the Type of FDR corrections
availables at the Alphapeptstats? Benjamini Hochberg?

Thank you

@steph-robinson
Copy link

Hi, I had a similar question coming here.
After going through some of the source code, I was able to see that the perform_ttest_analysis and perform_ttest functions found in alphapeptstats/alphastats/multicova/multicova.py will return the unadjusted and adjusted t and p-values according to the definition for s0 from Tusher et al 2001 PNAS. Later, the only options for FDR references 'BH' in some other calculations. However, how the qvalue and final significance is called in annotate_fdr_significance seems to be different than Benjamini Hochberg's method.

I'm curious if this is a permutation-based FDR correction like what's used in Perseus (Tyanova et al 2016), or is this another q-value method? I've tried passing an old dataset worked up in Perseus, but I get fairly different numbers of significant hits despite using the same s0 and kind of ttest. I do get the correct unadjusted p-values and correct adjusted t-values. I'm quite excited for this package, so thank you for making this code available!

@JuliaS92 JuliaS92 self-assigned this Nov 22, 2024
@JuliaS92 JuliaS92 added bug Something isn't working documentation Improvements or additions to documentation next release This is something we have already addressed on a branch or will address before the next release. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation next release This is something we have already addressed on a branch or will address before the next release.
Projects
None yet
Development

No branches or pull requests

3 participants