Group dependencies together for simplicity #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, restrict route permissions to only what we need
|
Checked commit bdunne@f53d90f with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint **
|
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Sep 27, 2023
Group dependencies together for simplicity (cherry picked from commit 176b398)
bdunne
added a commit
to bdunne/manageiq-pods
that referenced
this pull request
Sep 28, 2023
routes:
E0928 15:56:00.508746 1 reflector.go:147] pkg/mod/k8s.io/client-go@v0.28.0-rc.0/tools/cache/reflector.go:229: Failed to watch *v1.Route: failed to list *v1.Route: routes.route.openshift.io is forbidden: User "system:serviceaccount:petrosian-1:manageiq-operator" cannot list resource "routes" in API group "route.openshift.io" in the namespace "petrosian-1"
W0928 15:56:44.778213 1 reflector.go:535] pkg/mod/k8s.io/client-go@v0.28.0-rc.0/tools/cache/reflector.go:229: failed to list *v1.Route: routes.route.openshift.io is forbidden: User "system:serviceaccount:petrosian-1:manageiq-operator" cannot list resource "routes" in API group "route.openshift.io" in the namespace "petrosian-1"
routes/custom-host:
2023-09-28T16:30:38Z ERROR Reconciler error {"controller": "manageiq", "controllerGroup": "manageiq.org", "controllerKind": "ManageIQ", "ManageIQ": {"name":"manageiq-sample","namespace":"petrosian-1"}, "namespace": "petrosian-1", "name": "manageiq-sample", "reconcileID": "78aec8d7-f66d-4d63-8203-60f031384f19", "error": "Route.route.openshift.io \"httpd\" is invalid: spec.host: Forbidden: you do not have permission to set the host field of the route"}
Fryguy
added a commit
that referenced
this pull request
Sep 29, 2023
Fix route permissions issues after #989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, restrict route permissions to only what we need