Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[WIPTEST] Fix test_ansible_service_linked_vm #10089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gauravtalreja1
Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 commented May 4, 2020

Purpose or Intent

Fixed below error:

>       wait_for(ansible_service_request_funcscope.exists, num_sec=600)
E       wait_for.TimedOutError: Could not do 'function caller()' at /home/gtalreja/cfme/integration_tests/cfme/utils/varmeth.py:73 in time

test_embedded_ansible_services.py:877: TimedOutError

PRT Run

{{pytest: cfme/tests/ansible/test_embedded_ansible_services.py::test_ansible_service_linked_vm --long-running }}

@Gauravtalreja1 Gauravtalreja1 changed the title [WIPTEST] Fix test_ansible_service_linked_vm [RFR] Fix test_ansible_service_linked_vm May 4, 2020
@dajoRH dajoRH removed the WIP-testing label May 4, 2020
cfme/fixtures/ansible_fixtures.py Outdated Show resolved Hide resolved
@@ -135,13 +135,13 @@ def _finalize():


@pytest.fixture()
def ansible_linked_vm_action(appliance, local_ansible_catalog_item, create_vm):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete local_ansible_catalog_item fixture since it's no longer used anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No @valaparthvi , this fixture is being used in many tests, and some local fixtures also using this fixture

@dajoRH
Copy link
Contributor

dajoRH commented May 6, 2020

I detected some fixture changes in commit 2f65347

The global fixture ansible_catalog_item_funcscope is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_services.py
    • ansible_linked_vm_action

The global fixture ansible_service_request_funcscope is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_actions.py
  • cfme/tests/ansible/test_embedded_ansible_automate.py
  • cfme/tests/ansible/test_embedded_ansible_services.py

The global fixture ansible_service_funcscope is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_actions.py
  • cfme/tests/ansible/test_embedded_ansible_automate.py
  • cfme/tests/ansible/test_embedded_ansible_services.py

The local fixture ansible_linked_vm_action is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_services.py
    • ansible_policy_linked_vm

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@Gauravtalreja1 Gauravtalreja1 changed the title [RFR] Fix test_ansible_service_linked_vm [WIPTEST] Fix test_ansible_service_linked_vm May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants