Choice rule payload validation path #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
commented
Aug 1, 2024
| expect(described_class.new("$$.foo").value({})).to be_nil | ||
| expect { described_class.new("$$.foo").value({}, {"foo" => "bar"}) }.to raise_error(Floe::PathError, "Path [$$.foo] references an invalid value") |
There was a problem hiding this comment.
this is the essence of the issue
11 tasks
kbrock
force-pushed
the
choice_rule_payload_validation-path
branch
from
580ca92
to
dceeab9
Compare
|
update:
|
Before: If the path referenced a missing value in the input, treat it as a nil. After: If the path references a missing value in the input, raise an error. This makes it necessary to catch errors and ensure that the context is marked appropriately. Since a path lookup is so stringent, introduce the presence_check.
kbrock
force-pushed
the
choice_rule_payload_validation-path
branch
from
dceeab9
to
22c08f9
Compare
|
Checked commits kbrock/floe@29f923a~...22c08f9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
update:
|
kbrock
changed the title
|
WIP: moving stuff around. Want to get other stuff merged before this. |
kbrock
changed the title
|
WIP: oops. thought this was something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #189
Before
If the path referenced a missing value in the input, treat it as a nil.
After
If the path references a missing value in the input, raise an error.
presence_checkmethod to check if it is present up front.IsPresent: falseandIsPresent: true