Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Catch and display path errors #246

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[WIP] Catch and display path errors #246

wants to merge 12 commits into from

Commits on Jul 17, 2024

  1. Raise error for bad paths 

    Ensure they end up in "Error"
    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    825efcb View commit details
    Browse the repository at this point in the history

  2. Split out ChoiceRule spec to be similar to other specs 

    Components are exposed to make super easy to modify anything
    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8a65f97 View commit details
    Browse the repository at this point in the history

  3. Add choice_rule payload validation 

    Test for invalid compare key
    @agrare @kbrock
    agrare authored and kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ee39548 View commit details
    Browse the repository at this point in the history

  4. Move $variable from choice_rule to choice_rule/data

    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    25ce32a View commit details
    Browse the repository at this point in the history

  5. ChoiceRule validates next and data validates variable 

    Variable was only for Data and not for Not, Or, or And, so moved it to Data.

Since we want to add type checking, and that is Data specific,
it works better variable is over there.
    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    fbc6e20 View commit details
    Browse the repository at this point in the history

  6. Parse value/path in ChoiceRule::Date#initialize

    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    78ad596 View commit details
    Browse the repository at this point in the history

  7. More granular compare_key and determine path at initialization time

    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6befc14 View commit details
    Browse the repository at this point in the history

  8. Implement "IsNumeric": false

    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1a4587a View commit details
    Browse the repository at this point in the history

  9. Choice state detect data type errors

    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e1dfb4a View commit details
    Browse the repository at this point in the history

  10. Support choices that do not have a default defined

    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3a48034 View commit details
    Browse the repository at this point in the history

  11. Better error messages for parsing bad input path, reference path, and… 

    … payload templates
    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    273ea1c View commit details
    Browse the repository at this point in the history

  12. Better Runtime error detection for bad paths

    @kbrock
    kbrock committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8c0ee6c View commit details
    Browse the repository at this point in the history