Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool for copying refimages from previous version #4506

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Oct 21, 2024

Description

This adds ReferenceUpdater.update_from_previous_version() which pulls in reference images for an older version for every failed or missing reference image in a given pr, and uploads them to the given new version. This is meant to be used with breaking prs, where there might be changes to the previous version which should be merged into the breaking version.

Add a description of your PR here.

Type of change

  • tooling

@ffreyer ffreyer added the skip-changelog Skips changelog enforcer label Oct 21, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 21, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 6.41s (6.21, 6.72) 0.17+- 166.86ms (159.59, 180.00) 6.52+- 0.66s (0.46, 4.11) 0.81+- 7.01ms (6.75, 7.69) 0.23+- 25.95ms (25.45, 26.58) 0.45+-
master 6.41s (6.20, 6.71) 0.17+- 168.17ms (158.25, 185.30) 8.54+- 481.74ms (464.70, 512.09) 14.36+- 7.02ms (6.70, 7.56) 0.24+- 26.08ms (25.46, 26.58) 0.43+-
evaluation 1.00x invariant, -0.0s (-0.00d, 0.99p, 0.17std) 1.01x invariant, -1.32ms (-0.17d, 0.59p, 7.53std) 0.73x noisy🤷‍♀️, 0.18s (0.32d, 0.33p, 0.41std) 1.00x invariant, -0.01ms (-0.04d, 0.91p, 0.23std) 1.00x invariant, -0.13ms (-0.29d, 0.36p, 0.44std)
CairoMakie 5.98s (5.87, 6.24) 0.09+- 162.57ms (158.84, 180.50) 4.83+- 198.55ms (194.37, 216.53) 4.88+- 6.80ms (6.70, 7.21) 0.13+- 1.04ms (1.02, 1.07) 0.01+-
master 5.89s (5.81, 6.00) 0.06+- 162.30ms (157.84, 179.05) 5.46+- 196.87ms (193.16, 206.52) 3.17+- 6.74ms (6.66, 6.84) 0.05+- 1.07ms (1.05, 1.09) 0.01+-
evaluation 0.99x slower X, 0.09s (1.18d, 0.00p, 0.07std) 1.00x invariant, 0.27ms (0.05d, 0.87p, 5.15std) 0.99x invariant, 1.68ms (0.41d, 0.21p, 4.02std) 0.99x invariant, 0.06ms (0.61d, 0.07p, 0.09std) 1.03x faster ✓, -0.03ms (-2.28d, 0.00p, 0.01std)
WGLMakie 6.49s (6.42, 6.58) 0.05+- 161.46ms (158.17, 172.67) 3.27+- 5.73s (5.49, 5.89) 0.10+- 10.39ms (10.15, 10.86) 0.17+- 146.67ms (143.86, 157.45) 3.13+-
master 6.50s (6.44, 6.66) 0.07+- 171.73ms (158.11, 214.32) 21.69+- 5.93s (5.73, 6.13) 0.13+- 10.33ms (10.12, 10.69) 0.14+- 145.29ms (142.84, 147.38) 1.36+-
evaluation 1.00x invariant, -0.02s (-0.28d, 0.37p, 0.06std) 1.06x faster✅, -10.27ms (-0.66d, 0.05p, 12.48std) 1.03x faster ✓, -0.2s (-1.67d, 0.00p, 0.12std) 0.99x invariant, 0.06ms (0.40d, 0.21p, 0.16std) 0.99x invariant, 1.38ms (0.57d, 0.08p, 2.25std)

@MakieBot
Copy link
Collaborator

Benchmark Results

SHA: 87f1c706625f4c54255a277cb553e23204ace0e2

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

2 participants