Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtensionType and Extension1Type to Common.xsd for defined values of Extension element in "OperationsEventClassType" #54

Open
vitalJP opened this issue Oct 10, 2019 · 6 comments

Comments

@vitalJP
Copy link

vitalJP commented Oct 10, 2019

To align with Updated 95002, Operations Event Model
Solution
complexType name="OperationsEventClassType" element name="Extension"
CHANGE: type="IdentifierType" minOccurs="0" maxOccurs="unbounded"/>
TO: type="ExtensionType" minOccurs="0"/>

ADD ExtensionType and Extension1Type to Common.xsd for defined values of Extension element in "OperationsEventClassType" to align with Updated 950002, Operations Event Model

 <xsd:complexType name="Extension1Type">

        <xsd:simpleContent>

            <xsd:restriction base="CodeType">

                <xsd:enumeration value="Sealed"/>

                <xsd:enumeration value="NA"/>

                <xsd:enumeration value="Other"/>

            </xsd:restriction>

        </xsd:simpleContent>

    </xsd:complexType>

    

    <!--     -->    

    <xsd:complexType name="ExtensionType">

		<xsd:annotation> 

			<xsd:documentation>

Defines constraints on the inclusion of the respective operations event class in a hierarchy. 

Defined value are 

-sealed: no entry can use this entry as its parent;

-(No entry): no entry allows any entry to represent this entry as its parent /ancestor.

Extension can contain a set of entries of other operations event classes who represent this entry in their parent.

			</xsd:documentation>

		</xsd:annotation> 

         <xsd:simpleContent>

            <xsd:extension base="Extension1Type">

                <xsd:attribute name="OtherValue" type="xsd:string"/>

            </xsd:extension>

        </xsd:simpleContent>

    </xsd:complexType>	

Supporting Document
ISA-950002
Clause 5.11.2 Operations event class, Table 126 – Operations event class attributes

Impacted types
B2MML-OperatrionsEvent.xsd: OperationsEventClasssType
New B2MML-Common.xsd: ExtensionType
New B2MML-Common.xsd: Extension1Type

@Dennis-Brandl
Copy link
Contributor

Renamed to codetype to OperationsEventExtensionType and put it into the OperationsEvent.xsd file.
To be fixed in January 2020 Sprint.

@JoeDo
Copy link
Member

JoeDo commented Feb 3, 2020

Confirmed the addition of the OperationsEventExtensionType in OperationsEvent.xsd in the January-2020-Sprint branch. I'll circle back and Close this issue after the changes have been merged into Master.

@Dennis-Brandl
Copy link
Contributor

Changed as specified above.
Issue closed.

@gerardmoloneyetpartners

how do I see your commit for this change? its not listed here?

@Dennis-Brandl
Copy link
Contributor

Changed name to "OperationsEventExtension1Type" as specified in Jan 28th comment.

@Dennis-Brandl Dennis-Brandl reopened this Aug 17, 2020
@Dennis-Brandl
Copy link
Contributor

I started rebuilding the next version, and I am not sure what happended to this change. Let's leave it open until we find the right changed source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants