Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Add support for AppAuth #16

Open
LukasPoque opened this issue Nov 16, 2021 · 6 comments · May be fixed by #18
Open

Add support for AppAuth #16

LukasPoque opened this issue Nov 16, 2021 · 6 comments · May be fixed by #18
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@LukasPoque
Copy link
Owner

AppAuth is a client SDK for native apps to authenticate and authorize end-users using OAuth 2.0 and OpenID Connect. See: https://appauth.io/

Maybe it's a good idea to use this flutter wrapper and use the internal S3I OAuthProxy only on the web.

@LukasPoque LukasPoque added the enhancement New feature or request label Nov 16, 2021
@LukasPoque LukasPoque added this to the Version 0.6 milestone Nov 16, 2021
@LukasPoque LukasPoque self-assigned this Nov 16, 2021
@LukasPoque
Copy link
Owner Author

https://github.com/luis901101/oauth_webauth Looks nice too. But in my opinion, it is more insecure if a custom browser is used than the system one because the users can't be sure that the app won't stole their credentials. Therefore an independent browser is better.

@LukasPoque
Copy link
Owner Author

There is now a new class AppAuthFlow which uses the FlutterAppAuth package when running on android/ios and throws unsupported errors on the other platforms.

@LukasPoque
Copy link
Owner Author

One important note: See Android Setup and iOS Setup to prepare the app to be used with the new package.

@LukasPoque LukasPoque linked a pull request Apr 13, 2022 that will close this issue
@LukasPoque
Copy link
Owner Author

There is a problem with AppAuth if the client contains a colon ":" as we use in the S3I for all clients. This is a big problem cause either AppAuth fixes this bug or we need an option to create a new client without the s3i:UUID syntax.

@LukasPoque
Copy link
Owner Author

LukasPoque commented Apr 22, 2022

Another problem with the current AppAuth implementation is that only ios and android are supported. Since we can't conditional export only for those two platforms we're losing Windows/Linux/MacOS support in s3i_flutter. See the last pub dev score run: ["sdk:flutter","platform:android","platform:ios","platform:web","is:null-safe","license:mit"]

@LukasPoque
Copy link
Owner Author

Maybe this package worth a shot too: https://github.com/4D-Technologies/openidconnect_flutter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant