Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to peer code code review #8

Open
RuriEnciso opened this issue May 12, 2023 · 0 comments
Open

Peer to peer code code review #8

RuriEnciso opened this issue May 12, 2023 · 0 comments

Comments

@RuriEnciso
Copy link
Collaborator

Hi @Luffytaro22 ,

Good job so far! 👏. Your Code is Awesome! 💪

There are some few issues 🐛 that you still need to work 🔧 on though to go to the next project ⏭️ but you are almost there! 🏃

Don't Worry 🙏

It's ok to have bugs in your code 🐛. Especially if that's is your first project 1️⃣. Please, see this code review as a chance for you to learn practical coding skills and learn new tips that can improve your code quality 💯 and help you get a better job 💼.

I am going to guide you on how to fix them down below. 🤓

Required Changes ♻️

Check the comments under the review.

  • Could you consider removing the max-with of the * global container because it makes an issue with the sides of the webpage.
  • Kindly consider changing the height of the footer to get a better UX.
  • I think it should be better if you resize the img tags with other responsive sizes like rem , % , em. because they improve your responsive design.

Happy coding!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant