Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Version of the Budget-App - RoR Capstone Project #7

Closed
wants to merge 95 commits into from

Conversation

Luffytaro22
Copy link
Owner

Budget-App RoR Capstone project 🔥

  • Use of devise and CanCanCan gems to authenticate and authorize the users.
  • Created users, groups, purchases, and groups purchases tables migrations based on the Entity Relationship Diagram.
  • Created all the necessary models and controllers for the users, groups, and purchases with their respective validations.
  • Created all the devise views (login and register), the groups index (/groups) page with all the categories, the groups new (/groups/new) page to create a new category, the purchases index (/groups/:group_id/purchases) page to display all the transactions for a category, and the purchases new (/groups/:group_id/purchases/new) page to create a new transaction for a specific category (all of them as .erb files).
  • Created unit and integrations tests with RSpec, Capybara, and Factory Bot, for the models, requests, and views. All of them test the correct functionality of the entire application.
  • The application is successfully deployed and accessible through this link: https://budget-app-8wpl.onrender.com/
  • This is the video presentation of the project

⭐To the code reviewer 👨‍💻

💝 I really thank 🙇‍♂️ you, dear code reviewer 👨‍🎨 for dedicating your precious 🥇 time ⌚ to check the PR 🧾 .

I kindly ask 🙏 dear code reviewer 🤵 that if there is any kind of issue 🦯 in this project, please do list 📃 them in a descriptive 💡 manner and give your best suggestions 🎁 if needed.

Copy link

@Shedrack-Sunday Shedrack-Sunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Luffytaro22

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request 🔴

You have submitted a project, that does not follow the right gitflow. Features branches should push the dev branch.

  • Also, kindly fix the failed linters

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Copy link

@joel-kalema joel-kalema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request 🛑

pirates-of-the-caribbean-johnny-depp

  • You have submitted a project that has linters that do not pass, make sure you solve them and then ask again for a review

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @joel-kalema in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@Luffytaro22 Luffytaro22 deleted the develop branch October 19, 2023 13:57
Copy link

@rloterh rloterh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Manuel,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that has incorrect gitflow/ GitHub flow. Kindly note that the Pull Request for this activity should flow from feature into development, . Kindly use the correct gitflow, like you've done in #8.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants