Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sections are not optional #41

Open
domalex opened this issue Jul 21, 2022 · 0 comments
Open

Some sections are not optional #41

domalex opened this issue Jul 21, 2022 · 0 comments

Comments

@domalex
Copy link

domalex commented Jul 21, 2022

Thank you for your theme, Adam. Love it!

I forked and translated it into German. I discovered that some sections appear even though they are left empty. It would be great, you could make them disappear as described:

Every section is optional. If you do not include the publications array in your resume.json, no publications section will appear.

Sections concerned

Note: This is an example and not a complete list (e.g., awards has got the same issue)

The following sections are left empty in the resume.json file and cause different problems:

  • profiles
  • volunteer
  • publications
  • projects

On local server

  • profiles (an empty icon box remains)
  • volunteer (the section is visible)

Quick fix for volunteer: remove section from resume.json and comment the related lines in index.js. The empty icon box remains.

Publications and projects work as intended and don't show.

On online server (registry.jsonresume.org/)

Error message on registry.jsonresume.org:

JSON Resume

Resume json invalid - [{"code":"PATTERN","params":["^([1-2][0-9]{3}-[0-1][0-9]-[0-3][0-9]|[1-2][0-9]{3}-[0-1][0-9]|[1-2][0-9]{3})$",""],"message":"String does not match pattern ^([1-2][0-9]{3}-[0-1][0-9]-[0-3][0-9]|[1-2][0-9]{3}-[0-1][0-9]|[1-2][0-9]{3})$: ","path":"#/projects/0/endDate","description":"e.g. 2014-06-29"}] - Please visit https://github.com/jsonresume/registry-functions/issues/27

When deleting the sections volunteer, publications and projects from the resume.json, the file renders, but the profile section shows an empty icon box.

I hope this report helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant