Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link fixes #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ManuDeBuck
Copy link

I did two things:

  • Every link reachable via https is now changed from http to https.
  • I found a broken link and added a working link to the article (on the author's homepage).

Copy link
Member

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

If you don't want to depend on such an endpoint,
you download a **data dump**,
but then you're querying a local source instead of the Web.
With **subject pages**, servers do minimal effort,
but clients need to [work hard](http://squin.sourceforge.net/) to solve simple queries.
but clients need to [work hard](https://squin.sourceforge.net/) to solve simple queries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is only available on http apparently.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry

@@ -86,11 +86,11 @@ One such type is called a **Triple Pattern Fragment**
It consists of:

- **data** that corresponds to a triple pattern
_([example](http://data.linkeddatafragments.org/dbpedia?subject=&predicate=rdf%3Atype&object=dbpedia-owl%3ARestaurant))_.
_([example](https://data.linkeddatafragments.org/dbpedia?subject=&predicate=rdf%3Atype&object=dbpedia-owl%3ARestaurant))_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the links to TPF instances can remain linked to http. (unless you have a different opinion on this @RubenVerborgh?)

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.0//EN" "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in SVG files are not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants